[ 
https://issues.apache.org/jira/browse/FINERACT-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103377#comment-17103377
 ] 

Michael Vorburger commented on FINERACT-828:
--------------------------------------------

This just happened again in 
https://travis-ci.org/github/apache/fineract/builds/685073748 for 
https://github.com/apache/fineract/pull/852 (which is totally unrelated) - it's 
clearly "flaky". This exact error illustrates more clearly than above what the 
problem is:

{noformat}org.apache.fineract.notification.StorageTest > 
testNotificationStorage FAILED

    Argument(s) are different! Wanted:

    notificationGeneratorWritePlatformService.create(

        refEq(org.apache.fineract.notification.domain.Notification@5908c1c9)

    );

    -> at 
org.apache.fineract.notification.StorageTest.testNotificationStorage(StorageTest.java:125)

    Actual invocations have different arguments:

    notificationGeneratorWritePlatformService.create(

        org.apache.fineract.notification.domain.Notification@52226f9b

    );

    -> at 
org.apache.fineract.notification.service.NotificationWritePlatformServiceImpl.insertIntoNotificationGenerator(NotificationWritePlatformServiceImpl.java:93)

        at 
org.apache.fineract.notification.StorageTest.testNotificationStorage(StorageTest.java:125){noformat}

I'm proposing to add a {{toString()}} to {{Notification}} in 
https://github.com/apache/fineract/pull/858, in the hope that this will help to 
fully understand, and let someone fix, this problem when it happens next time.

> StorageTest is flaky and sometimes arbitrarily fails
> ----------------------------------------------------
>
>                 Key: FINERACT-828
>                 URL: https://issues.apache.org/jira/browse/FINERACT-828
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>            Priority: Major
>
> https://github.com/apache/fineract/pull/692, a trivial Pull Request adding a 
> new GitHub Action but not modifying any code, failed on 
> https://travis-ci.org/apache/fineract/builds/636252981 due to:
> {code}> Task :test
> org.apache.fineract.notification.StorageTest > testNotificationStorage FAILED
>     org.mockito.exceptions.verification.junit.ArgumentsAreDifferent at 
> StorageTest.java:124
> (...)
> 17 tests completed, 1 failed, 2 skipped{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to