[ 
https://issues.apache.org/jira/browse/FINERACT-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109212#comment-17109212
 ] 

Michael Vorburger commented on FINERACT-911:
--------------------------------------------

The problem I've described above is actually solved easy enough simply using 
something like this on the respective CI/CD pipeline:

{{git clone --depth 1 --no-tags --branch develop 
https://github.com/apache/fineract.git}}

But FINERACT-983 is another related problem.

Resolving this.

> Alternative way(s) to set Git revision on CI systems which do shallow git 
> clone
> -------------------------------------------------------------------------------
>
>                 Key: FINERACT-911
>                 URL: https://issues.apache.org/jira/browse/FINERACT-911
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>            Priority: Major
>
> FINERACT-883 will expose Fineract build's Git revision on /actuator/info HTTP 
> API endpoint.
> But as discussed on https://github.com/apache/fineract/pull/778, the project 
> should still build even if there is no `.git/` directory present.  This could 
> happen if someone builds inside a Docker container, or some of things I have 
> in mind for the future (https://github.com/actions/checkout note `--depth` 
> and `--unshallow`, and e.g. 
> https://cloud.google.com/cloud-build/docs/running-builds/create-manage-triggers
>  doing a _shallow_ clone, by default)... let me open new FINERACT-tbd to look 
> into that, after this is merged. (On TravisCI it's fine though, because they 
> do `git clone --depth=50`.)
> The goal of this issue is to look into alternative ways to set the Fineract 
> Release Git revision details. For example, using the GitHub Checkout Action, 
> it may be possible to either specify the right parameter for depth 1. If that 
> is impossible, then perhaps the Git revision could be "passed through" via 
> some... environment variable?
> Let's deal with this after FINERACT-883, and once we see real problems.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to