[
https://issues.apache.org/jira/browse/FINERACT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yemdjih Kaze Nasser updated FINERACT-987:
-----------------------------------------
Description:
While trying to resolve https://github.com/apache/fineract/pull/915, I stumbled
upon
{code:java}
org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge since first
historized release unspecified
In class org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge
In method
org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge.percentageOf(BigDecimal,
BigDecimal)
Parameter value
At SavingsAccountCharge.java:[lines 540-548]
value must be non-null but is marked as nullable
This parameter is always used in a way that requires it to be non-null, but the
parameter is explicitly annotated as being Nullable. Either the use of the
parameter or the annotation is wrong.
{code}
Seems to be related to this [line of
code|https://github.com/apache/fineract/blob/beee2e5330b35f07ed16ba7019b57b8ab75e4e02/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountCharge.java#L478]
which sets passes a null value to a method which does not handle null values.
The reason for the use of null values is not clear to me but this is a glitch
which be troublesome.
was:
While trying to resolve https://github.com/apache/fineract/pull/915, I stumbled
upon
{code:java}
org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge since first
historized release unspecified
In class org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge
In method
org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge.percentageOf(BigDecimal,
BigDecimal)
Parameter value
At SavingsAccountCharge.java:[lines 540-548]
value must be non-null but is marked as nullable
This parameter is always used in a way that requires it to be non-null, but the
parameter is explicitly annotated as being Nullable. Either the use of the
parameter or the annotation is wrong.
{code}
Seems to be related to this
[link|https://github.com/apache/fineract/blob/beee2e5330b35f07ed16ba7019b57b8ab75e4e02/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountCharge.java#L478]
which sets passes a null value to a method which does not handle null values.
The reason for the use of null values is not clear to me but this is a glitch
which be troublesome.
> Replace null values with zero for bigDecimal values
> ---------------------------------------------------
>
> Key: FINERACT-987
> URL: https://issues.apache.org/jira/browse/FINERACT-987
> Project: Apache Fineract
> Issue Type: Bug
> Components: Savings
> Reporter: Yemdjih Kaze Nasser
> Priority: Critical
>
> While trying to resolve https://github.com/apache/fineract/pull/915, I
> stumbled upon
> {code:java}
> org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge since first
> historized release unspecified
> In class org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge
> In method
> org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge.percentageOf(BigDecimal,
> BigDecimal)
> Parameter value
> At SavingsAccountCharge.java:[lines 540-548]
> value must be non-null but is marked as nullable
> This parameter is always used in a way that requires it to be non-null, but
> the parameter is explicitly annotated as being Nullable. Either the use of
> the parameter or the annotation is wrong.
> {code}
> Seems to be related to this [line of
> code|https://github.com/apache/fineract/blob/beee2e5330b35f07ed16ba7019b57b8ab75e4e02/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountCharge.java#L478]
> which sets passes a null value to a method which does not handle null values.
> The reason for the use of null values is not clear to me but this is a glitch
> which be troublesome.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
