[ 
https://issues.apache.org/jira/browse/FINERACT-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120124#comment-17120124
 ] 

Petri Tuomola commented on FINERACT-1005:
-----------------------------------------

The other two issues were easy to fix:
 * Validation for externalId was missing - I've added that
 * Some test request were missing mandatory fields (joiningDate etc) that were 
causing the validation test requests to fail
 
Will send the pull request later

> Fix Failing test in org.apache.fineract.integrationtests.StaffTest 
> -------------------------------------------------------------------
>
>                 Key: FINERACT-1005
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1005
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Percy Ashu
>            Priority: Blocker
>
> testStaffUpdateWrongActiveState test returns 200 instead of expected 400 when 
> updating isactive with wrong value.
> testStaffUpdateLongExternalIdError test returns 500 instead of 400
>  testStaffCreateMaxNameLength test show return 200 with number of characters 
> 50 but seems the random generator generates an additional character which 
> then cause the test to fail.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to