Michael Vorburger created FINERACT-1014:
-------------------------------------------
Summary: From/To Amount Range and Period Validatation broken
Key: FINERACT-1014
URL: https://issues.apache.org/jira/browse/FINERACT-1014
Project: Apache Fineract
Issue Type: Bug
Reporter: Michael Vorburger
Assignee: Yemdjih Kaze Nasser
[~xurror] work for FINERACT-822 in
https://github.com/apache/fineract/pull/951/files thanks to
https://errorprone.info/bugpattern/CompareToZero has uncovered real bugs (not
just "nice to have for hypothetical exotic JDKs, like that Error Prone doc
makes it sound) in Fineract's From/To Amount Range and Period Validatation..
there were 4 places which did a Comparable compareTo() > 1 - which is obviously
never the case; those validations were simply completely broken, and we're
fixing them as part of enabling code quality checks with Error Prone.
In theory, this code break clients who sent this wrong to the API, but that's a
Good Thing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
