[
https://issues.apache.org/jira/browse/FINERACT-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reopened FINERACT-935:
----------------------------------------
> This appears to be a valid exception. This wrapper was built specifically for
> error handling. In the code, exception is to be thrown when information not
> found.
Nope! :P As per https://github.com/apache/fineract/#logging-guidelines, quote:
{quote}do NOT include e.g. validation errors for incoming API requests - that
is signaled through the API response - and does (should) not be logged as an
error.{quote}
We need an integration test which verified that whatever can cause this
condition is returning an appropriate response in the REST API - and does not
log it.
[~natashan] do you want to work on this? If not, please un-assign this issue
from yourself.
> StaffNotFoundException at StaffRepositoryWrapper
> ------------------------------------------------
>
> Key: FINERACT-935
> URL: https://issues.apache.org/jira/browse/FINERACT-935
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Assignee: Natasha Natarajan
> Priority: Major
> Fix For: 1.4.0
>
>
> See FINERACT-932 for general background, and determine if this error log can
> and should be "fixed", or if this represents a condition that shouldn't be
> logged as an error (or conclude that this is a totally valid error log that
> is useful, any why):
> {code}org.apache.fineract.organisation.staff.exception.StaffNotFoundException
> at
> org.apache.fineract.organisation.staff.domain.StaffRepositoryWrapper.lambda$findByOfficeHierarchyWithNotFoundDetection$1(StaffRepositoryWrapper.java:54)
> at java.util.Optional.orElseThrow(Optional.java:290)
> at
> org.apache.fineract.organisation.staff.domain.StaffRepositoryWrapper.findByOfficeHierarchyWithNotFoundDetection(StaffRepositoryWrapper.java:54)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:248)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke(<generated>){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
