[
https://issues.apache.org/jira/browse/FINERACT-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127638#comment-17127638
]
Michael Vorburger edited comment on FINERACT-936 at 6/7/20, 12:53 PM:
----------------------------------------------------------------------
> This exception appears valid as this is what is expected of the class. It is
> properly throwing an exception when a validation error is encountered.
Nope! As per https://github.com/apache/fineract/#logging-guidelines, quote:
{quote}do NOT include e.g. validation errors for incoming API requests - that
is signaled through the API response - and does (should) not be logged as an
error.{quote}
We need an integration test which verified that whatever can cause this
condition is returning an appropriate response in the REST API - and does not
log it.
[~natashan] do you want to work on this? If not, please un-assign this issue
from yourself.
was (Author: vorburger):
> This exception appears valid as this is what is expected of the class. It is
> properly throwing an exception when a validation error is encountered.
Nope! As per https://github.com/apache/fineract/#logging-guidelines, quote:
{quote}do NOT include e.g. validation errors for incoming API requests - that
is signaled through the API response - and does (should) not be logged as an
error.{quote}
We need an integration test which verified that whatever can cause this
condition is returning an appropriate response in the REST API - and does not
log it.
Natasha Natarajan do you want to work on this? If not, please un-assign this
issue from yourself.
> PlatformApiDataValidationException at ClientDataValidator
> ---------------------------------------------------------
>
> Key: FINERACT-936
> URL: https://issues.apache.org/jira/browse/FINERACT-936
> Project: Apache Fineract
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Michael Vorburger
> Assignee: Natasha Natarajan
> Priority: Major
> Fix For: 1.4.0
>
>
> See FINERACT-932 for general background, and determine if this error log can
> and should be "fixed", or if this represents a condition that shouldn't be
> logged as an error (or conclude that this is a totally valid error log that
> is useful, any why):
> {code}
> org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException
> at
> org.apache.fineract.portfolio.client.data.ClientDataValidator.throwExceptionIfValidationWarningsExist(ClientDataValidator.java:584)
> at
> org.apache.fineract.portfolio.client.data.ClientDataValidator.validateForCreate(ClientDataValidator.java:231)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:224)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke(<generated>){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
