[
https://issues.apache.org/jira/browse/FINERACT-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135123#comment-17135123
]
Michael Vorburger edited comment on FINERACT-955 at 6/14/20, 11:20 AM:
-----------------------------------------------------------------------
I'm linking this to Blocking FINERACT-932, because the following error appears
on https://www.fineract.dev logs, and is, of course, related to this:
{noformat}java.lang.IllegalArgumentException: Access key cannot be null.
at com.amazonaws.auth.BasicAWSCredentials.<init>
(BasicAWSCredentials.java:37)
at
org.apache.fineract.infrastructure.documentmanagement.contentrepository.S3ContentRepository.<init>
(S3ContentRepository.java:57)
at
org.apache.fineract.infrastructure.documentmanagement.contentrepository.ContentRepositoryFactory.createS3DocumentStore
(ContentRepositoryFactory.java:57)
at
org.apache.fineract.infrastructure.documentmanagement.contentrepository.ContentRepositoryFactory.getRepository
(ContentRepositoryFactory.java:45)
at
org.apache.fineract.infrastructure.documentmanagement.service.DocumentWritePlatformServiceJpaRepositoryImpl.createDocument
(DocumentWritePlatformServiceJpaRepositoryImpl.java:71)
at
org.apache.fineract.infrastructure.documentmanagement.service.DocumentWritePlatformServiceJpaRepositoryImpl.createInternalDocument
(DocumentWritePlatformServiceJpaRepositoryImpl.java:99){noformat}
BTW: It appears that by default by have the {{S3ContentRepository}} enabled
somehow somewhere? That seems wrong, to me... the code shouldn't be hard-coded
to assume AWS, agreed? IMHO by default we should have a NOOP implementation of
{{ContentRepository}}, and then have a configuration property to choose between
the {{FileSystemContentRepository}}, and the AWS {{S3ContentRepository}} and a
new Google GCS one to be written for this issue.
[~xurror] or [~Percy Ashu] or [~awasum] (or [~ptuomola]) I'm sure you all have
enough on your plate already, but if / when you are looking for something...
this could be a "fun" thing to work on, some day? Perhaps later during, or even
after, your GSOC.
I'm aslo adding the _beginner_ label to this one, on the off chance that
someone new to the project would like to pick this up...
was (Author: vorburger):
I'm linking this to Blocking FINERACT-932, because the following error appears
on https://www.fineract.dev logs, and is, of course, related to this:
{noformat}java.lang.IllegalArgumentException: Access key cannot be null.
at com.amazonaws.auth.BasicAWSCredentials.<init>
(BasicAWSCredentials.java:37)
at
org.apache.fineract.infrastructure.documentmanagement.contentrepository.S3ContentRepository.<init>
(S3ContentRepository.java:57)
at
org.apache.fineract.infrastructure.documentmanagement.contentrepository.ContentRepositoryFactory.createS3DocumentStore
(ContentRepositoryFactory.java:57)
at
org.apache.fineract.infrastructure.documentmanagement.contentrepository.ContentRepositoryFactory.getRepository
(ContentRepositoryFactory.java:45)
at
org.apache.fineract.infrastructure.documentmanagement.service.DocumentWritePlatformServiceJpaRepositoryImpl.createDocument
(DocumentWritePlatformServiceJpaRepositoryImpl.java:71)
at
org.apache.fineract.infrastructure.documentmanagement.service.DocumentWritePlatformServiceJpaRepositoryImpl.createInternalDocument
(DocumentWritePlatformServiceJpaRepositoryImpl.java:99){noformat}
BTW: It appears that by default by have the {{S3ContentRepository}} enabled
somehow somewhere? That seems wrong, to me... the code shouldn't be hard-coded
to assume AWS, agreed? IMHO by default we should have a NOOP implementation of
{{ContentRepository}}, and then have a configuration property to choose between
a {{java.io.File}} based one (which we already have, as far as I know), and the
AWS {{S3ContentRepository}} and a new Google GCS one to be written for this
issue.
[~xurror] or [~Percy Ashu] or [~awasum] (or [~ptuomola]) I'm sure you all have
enough on your plate already, but if / when you are looking for something...
this could be a "fun" thing to work on, some day? Perhaps later during, or even
after, your GSOC.
I'm aslo adding the _beginner_ label to this one, on the off chance that
someone new to the project would like to pick this up...
> ContentRepository for Google Cloud Storage
> ------------------------------------------
>
> Key: FINERACT-955
> URL: https://issues.apache.org/jira/browse/FINERACT-955
> Project: Apache Fineract
> Issue Type: New Feature
> Reporter: Michael Vorburger
> Priority: Major
> Labels: beginner
>
> Similarly to S3ContentRepository, a {{ContentRepository}} for Google Cloud
> Storage (GCS) could be useful, for FINERACT-786, and I would use it on
> https://www.fineract.dev.
> It may actually even be possible to use the S3 API, but a GCS native
> implementation is probably smoother and easier to use. One thing in
> particular I'm hoping for is that it could pick up the required
> authentication when running on GCloud automatically from some service account
> environment variables which as far as I know are present there; it would be
> nice, if possible, if there was no need, or as little as possible, need for
> additional configuration parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
