[
https://issues.apache.org/jira/browse/FINERACT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141128#comment-17141128
]
Michael Vorburger commented on FINERACT-942:
--------------------------------------------
I had a quick look at what's left here, and noticed that [~Manthan] you
actually made good progress here.. if I'm not mistaken, what is now left here
is:
* AvoidHidingCauseException which we are discussing in
https://github.com/apache/fineract/pull/1079
* IllegalCatch, of which there are unfortunately quite a lot (about x80 or so;
a handful in integration test, more in real code)
If I find the time, I may raise a PR which won't completely fix the
IllegalCatch, but can perhaps help to better illustrate how to deal with it
where.
> Make Checkstyle detect bad logging anti-patterns (and fix problems found)
> -------------------------------------------------------------------------
>
> Key: FINERACT-942
> URL: https://issues.apache.org/jira/browse/FINERACT-942
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Manthan Surkar
> Priority: Major
> Fix For: 1.4.0
>
>
> A particularly useful part of FINERACT-821, helping to detect real errors in
> Fineract and not just formating, would be to enable the following in
> fineract-provider/config/checkstyle/checkstyle.xml, and fix any problems that
> this finds:
> 1. RegexpSinglelineJava / printStackTrace
> 2. IllegalCatch, IllegalThrows, MutableException,
> AvoidHidingCauseExceptionCheck
> 3.
> [EmptyCatchBlock|https://checkstyle.sourceforge.io/config_blocks.html#EmptyCatchBlock]
> Nota bene that we already have FINERACT-696, but this is complementary to
> that.
> One thing this should detect is e.g. the bad wrong emtpy
> catch(MessagingException e) in EmailMessageJobEmailServiceImpl.
> It may lead to more of FINERACT-932, which would be a Good Thing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
