[
https://issues.apache.org/jira/browse/FINERACT-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154056#comment-17154056
]
Manthan Surkar commented on FINERACT-837:
-----------------------------------------
[~ptuomola] Hello!
This really made huge progress! Greatt! Since most of the part is now done, I
was looking into FINERACT-1045 which includes replacing the links to old docs
to the local one.
Having seen your comment, the metadata(initial summary) is still not present in
the fineract.json (is that why this is still open?) Since response.json is to
be removed FINERACT-1045 I don't think we should fix the URLs in it, but add
the correct one to the config for fineract.json. Is that only thing that's
remaining? (at least as I can see?) Can you please tell if you have already/or
are working on that? (I can pick the adding part if you are not working already
)
After that,
I tested the fineract.json and it looks good, I was worried about the missing
files though(js files) which are needed by swagger to run and were deleted in
https://github.com/apache/fineract/pull/1069/files . I hope this question makes
sense- should we not add it to the correct place (or maybe it is somehow
downloaded with the version if that's the case). Is it something to be worked
on? I was confused on how that thing works.
[~ptuomola] can you please answer the doubts?
> Make swagger-ui/response.json (?) a pure built time artifact, and remove it
> from Git
> ------------------------------------------------------------------------------------
>
> Key: FINERACT-837
> URL: https://issues.apache.org/jira/browse/FINERACT-837
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Michael Vorburger
> Assignee: Petri Tuomola
> Priority: Major
>
> Once FINERACT-835 is fully implemented (do not start working on this until
> FINERACT-835 is merged), and just in order to reduce confusion about what is
> manually maintained and what is provided by the build, IMHO we really should
> make swagger-ui/response.json (or whatever will replace it?) a pure built
> time artifact.
> What I mean is that {{./gradlew build}} should produce this file at the
> appropriate place under {{build/}}, from where it should be picked up and
> included in the right place in the WAR. That file should then be removed from
> Git in {{src/main/resources/swagger-ui/response.json}} where it currently
> lives.
> I guess it would be cool to make this change after having the test proposed
> in FINERACT-836 just to "prove" that "it (?) still works as before and
> nothing broke".
> The assumption I've made here is that it's best to have this JSON file built
> at run-time. I know little about Swagger, and if the conclusion is that it's
> better and fine to just have something (Swagger runtime) build the Swagger
> JSON (YAML?) through scanning the annotations at runtime, and that's how this
> is typically done, then we can of course forget about, and just remove the
> {{src/main/resources/swagger-ui/response.json}} completely.
> [~kangbreder] would you like to do this? Please raise PR with ONLY this
> change, nothing else.
> [~awasum] [~sanyam] ([~sanyam96] ?) FYI
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
