[
https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184780#comment-17184780
]
Michael Vorburger commented on FINERACT-1129:
---------------------------------------------
Re. the client JAR, probably just following
[https://github.com/apache/fineract/#apache-fineract-platform-api] =>
[https://github.com/apache/fineract/blob/develop/docs/developers/swagger/client.md]
will get you there? But I would love [~Grandolf49] to chime in and work with
you here. Note that he just changed it in
[https://github.com/apache/fineract/pull/1271], which he hasn't proposed to
backport to 1.4.0, yet. That's if he's interested in getting the Swagger Client
JAR shipped in the upcoming 1.4.0 release distribution already. It's an
assumption I just boldly made, but haven't actually verified with him... :P if
that's a little premature, and the client JAR isn't really ready for
distribution just yet, then no stress at all, let's skip it for 1.4.0, and
[~Grandolf49] can add it later through a follow-up PR extending the new Gradle
task, for a future 1.5.0?
I've actually pulled your branch already, looking at
[https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1129],
and can provide some feedback before you raise your PR already, if that's OK
with you:
First of all, this is very cool! I've compared the previous
apache-fineract-1.3.0-binary and a new apache-fineract-1.4.0-binary built
through this, and they look similar enough, to me. Have noticed how you're
including {{licenses/}} which is great and actually required by ASF AFAIK, so
looks like that was missed in the past.
One important point: It currently only builds the
{{apache-fineract-$releaseVersion-binary.tar.gz}} - will you make it build
those {{apache-fineract-*-src.tar.gz}} we need on
[https://fineract.apache.org/#downloads] as well?
Smaller feedback on the new Gradle task name - do you want to drop the
{{fineract}} prefix just in your {{fineractRelease}} Gradle task name? It's
e.g. just {{./gradlew build}} and not fineract* for everything else after all,
so how about just "release", or (even better IMHO, if that works) just
"distribution", in line with this using the distribution Gradle plugin and
producing {{build/distributions/}}.
Lastly, let's "document" this by adding a line to
[https://github.com/apache/fineract/blob/develop/README.md#releasing] about it
as well, while we're at it? I guess just _"(...) available on
[http://fineract.apache.org|http://fineract.apache.org/], from
`{{build/distributions/}}` after running `{{./gradlew fineractRelease}}`."_ (or
{{distribution}} instead of {{fineractRelease}}, if you rename it) is what this
boils down to?
If I can provide a very minor more general feedback, your Commit Message should
include this JIRA id, so e.g. "Add release task to Gradle (FINERACT-1129)"
instead of just "Add release task".
[~ptuomola] this will do the most important part of FINERACT-876! :D
> Gradle task to create release package
> -------------------------------------
>
> Key: FINERACT-1129
> URL: https://issues.apache.org/jira/browse/FINERACT-1129
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.4.0
> Reporter: Aleksandar Vidakovic
> Assignee: Aleksandar Vidakovic
> Priority: Minor
> Fix For: 1.4.0
>
>
> Add Gradle task to create release package with following artifacts:
> * WAR
> * server JAR
> * client JAR
> * README
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
