[
https://issues.apache.org/jira/browse/FINERACT-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193825#comment-17193825
]
Michael Vorburger commented on FINERACT-1144:
---------------------------------------------
IMHO this requires FINERACT-1145 re. missing doc, first. (Personally I wouldn't
be willing to review and merge code for a feature that I don't know how to test
at least manually due to missing documentation.)
It would also be "nice to have" if this could directly "include" FINERACT-1143
re. test coverage (although that could also be added separately later, and this
already resolved with that).
> OAuth broken (or is it?)
> ------------------------
>
> Key: FINERACT-1144
> URL: https://issues.apache.org/jira/browse/FINERACT-1144
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
> Reporter: Michael Vorburger
> Priority: Major
> Fix For: 1.5.0
>
>
> Reading [~avikganguly010] comment in FINERACT-629 that "the spring oauth
> changes we did broke Oauth", and a number of (failed, uncompleted, abandoned)
> PRs by [~saransh] related to FINERACT-1012 and FINERACT-1057 gives me the
> impression that Fineract's OAuth support feature may actually currently be
> broken.
> Let's use this issue for someone to investigate and propose a PR to fix
> Fineract's OAuth support. I see this as a separate issue from FINERACT-1012.
> It would be "fair game", IMHO, to propose to just e.g. revert whatever is
> known to have broken it (if someone knows what that is - I personally do not)
> - and then deal separate and later with respective 3rd party upgrades, or
> whatever.
> If it's not broken and works on develop (and thus 1.4.0) as-is, then this
> issue should be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
