[
https://issues.apache.org/jira/browse/FINERACT-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208006#comment-17208006
]
Aleksandar Vidakovic commented on FINERACT-1175:
------------------------------------------------
[~vorburger] In my fork that I told you about the other day I got rid of all
those XML files except for orm.xml and ehcache.xml. spmContext.xml is not
necessary at all with with a recent Spring Boot (which we have now); it can be
replaced with a simple annotation and/or by just including the Spring Boot JPA
starter dependency which takes care of this with - kind of - standardized
application.properties (didn't do that in my fork, because I wanted to stay as
close as possible to the current dependencies, but in general I think this is
the preferred way to do things). The starter dependencies would also eliminate
the current overly complex way to configure the JDBC datasource... at least the
configuration for the main DB can be simplified that way.
Concerning the separate component scans you mentioned above: I agree that this
too is to detailed (and again, the classic xml configuration is not necessary).
Additionally doing it that way you always have to touch it when a new package
is added (doesn't happen that often admittedly, but still inconvenient). If the
idea here was to save some time on the class scans... I don't think it matters
significantly. I am all for using the base package with Asterisks. That way you
never have to think about this again.
> Fix spm.repository / spm.domain JPA bug (?), and simplify appContext.xml
> ------------------------------------------------------------------------
>
> Key: FINERACT-1175
> URL: https://issues.apache.org/jira/browse/FINERACT-1175
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Assignee: Michael Vorburger
> Priority: Major
>
> While I was working on FINERACT-1127, I've noticed that appContext.xml
> individually lists 10+ packages.. why not just use org.apache.fineract.** ?
> There is also a
> fineract-provider/src/main/resources/META-INF/spring/spmContext.xml, which
> seems weird.. why is that, and only that, in a separate file, instead of
> listed in appContext.xml? Would seem more consistent to have all in one.
> Most importantly, perhaps, the {{<jpa:repositories
> base-package="org.apache.fineract.spm.repository"/>}} in spmContext.xml seems
> inconsistent with appContext.xml.. shouldn't that be
> {{org.apache.fineract.spm.domain}}, instead? Or are the other ones wrong?
> (And this is another reason why having them all together in a single place
> seems easier, to see differences.)
> [~ptuomola] [~aleks] do you perhaps have any thoughts about this?
> [~xurror] ([~kaze] ?) I'm not sure if this is something that particularly
> interests you, in the context of the OpenJPA to EclipseLink migration, but I
> thought I would just mention it here FYI, and on the off chance that this is
> causing you any issues during that project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
