[ 
https://issues.apache.org/jira/browse/FINERACT-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209942#comment-17209942
 ] 

Aleksandar Vidakovic edited comment on FINERACT-1171 at 10/8/20, 12:32 AM:
---------------------------------------------------------------------------

[~vorburger] [~ptuomola] [~edcable]

Some more fixes:
 * SQL tasks re-activated (some minor Groovy code cleanups)
 * fixed Checkstyle configuration; generated code should not be included in the 
checks (activated the "suppressions" module for that; all other attempts via 
Gradle Checkstyle plugin configuration failed)
 * minor stuff like using aws-java-sdk-bom to manage AWS dependencies 
(including the S3 one we are using)
 * prepared Maven publish of artifacts; could be used for fineract-client and 
fineract-api... which would be very convenient for development

You can test yourself by executing (IMPORTANT: location of the Gradle Wrapper 
changed, is now in the project root folder and not in fineract-provider 
anymore):

./gradlew clean build doc

This generates client, provider, distribution files and a very simple 
documentation (PDF and HTML; as said before will add content when this 
eventually merges back to develop).

I've also made sure that this feature branch/PR (not yet created) is in sync 
with upstream develop.

If you want to import the project in your IntelliJ then just do as usual by 
using the new build.gradle file in the root folder and using "Open as 
project..". If you had Fineract already imported earlier (very likely) then 
it's probably a good idea to invalidate IntelliJ's caches (see file menu) and 
restart.

Remaining stuff to solve:
 * I had to disable the compiler parameter "-Werror", because there's one 
warning left to solve in the generated fineract-client code
 * I have to find a better solution for the fineract.yaml file; at the moment I 
am storing it with fineract-client... which is a duplication, because it's 
generated during compile time in fineract-provider; my problem is only that I 
can't convince Gradle at the moment to execute the modules in the correct order 
(first: fineract-provider, second: fineract-client); that way I could consume 
the Swagger file from fineract-provider and don't have to maintain a copy in 
Git; for now this works and creates just a small inconvenience when we release


was (Author: aleks):
[~vorburger] [~ptuomola] 

Some more fixes:
 * SQL tasks re-activated (some minor Groovy code cleanups)
 * fixed Checkstyle configuration; generated code should not be included in the 
checks (activated the "suppressions" module for that; all other attempts via 
Gradle Checkstyle plugin configuration failed)
 * minor stuff like using aws-java-sdk-bom to manage AWS dependencies 
(including the S3 one we are using)

You can test yourself by executing (IMPORTANT: location of the Gradle Wrapper 
changed, is now in the project root folder and not in fineract-provider 
anymore):

./gradlew clean build doc

This generates client, provider, distribution files and a very simple 
documentation (PDF and HTML; as said before will add content when this 
eventually merges back to develop).

I've also made sure that this feature branch/PR (not yet created) is in sync 
with upstream develop.

If you want to import the project in your IntelliJ then just do as usual by 
using the new build.gradle file in the root folder and using "Open as 
project..". If you had Fineract already imported earlier (very likely) then 
it's probably a good idea to invalidate IntelliJ's caches (see file menu) and 
restart.

> Multi-module configuration for Gradle
> -------------------------------------
>
>                 Key: FINERACT-1171
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1171
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.5.0
>            Reporter: Aleksandar Vidakovic
>            Assignee: Aleksandar Vidakovic
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Use the build.gradle file in the root folder rather than in fineract-provider 
> to import the project in IDEs.
> Note: this will force everyone to re-import the project in their IDEs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to