[ 
https://issues.apache.org/jira/browse/FINERACT-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211137#comment-17211137
 ] 

Petri Tuomola commented on FINERACT-1187:
-----------------------------------------

[~vorburger]  - actually I think it was my fault!

Looks like the Gradle war task automatically picks up whatever you've set to 
project property "version" and appends it to the filename of the war. So when I 
fixed the build so that it would work outside git repository, I used project 
property "version" to store the version number for Swagger UI - and that is now 
being automatically picked up also by the Gradle war task.

Sorry about this! Will send a PR to fix this. 

> WAR should have fixed file name
> -------------------------------
>
>                 Key: FINERACT-1187
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1187
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Michael Vorburger
>            Priority: Blocker
>
> Something somewhere in 1.4.0 made the built WAR file contain release number 
> information ({{./gradlew bootWAR}} creates 
> {{fineract-provider-release-1.4.0-660-g2ce7ed2.war}}).
> This means that end-users have to rename the WAR file back to 
> {{fineract-provider}} as it used to be when they deploy it to Tomcat, and 
> causes confusion, as seen e.g. on the recent "Finereract Customization" email 
> thread.
> [~aleks] [~ptuomola] I missed when exactly that happened and how (probably it 
> was part of automating the 1.4.0 release work?), and it matters only for 
> historical context - was there a "need" for it, or was it just "nice"? (The 
> same information is of course already available on 
> https://demo.fineract.dev/fineract-provider/actuator/info.)
> How about we revert that to how it used to be?
> PS: The Boot JAR doesn't suffer from this problem, so we can keep that named 
> as is.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to