[
https://issues.apache.org/jira/browse/FINERACT-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216265#comment-17216265
]
Michael Vorburger commented on FINERACT-1209:
---------------------------------------------
[~aleks] how is your.. "availability" in the next few days? I'm just
contemplating if we could do what we are discussing here rather sooner than
later already - I could use it for new ITs that I want to write soon-ish for
FINERACT-1218! Re. _how could we best get started with this,_ here's a specific
proposal:
0. We take a moment to go over any open PRs that touch
{{fineract-provider/src/integrationTest/}}, and either help to get them merged
ASAP, or give them a heads up comment that we're about to break them due to a
massive upcoming move, and that they'll get conflicts.
1. We create 1 PR with a new {{fineract/integration-tests/}} (?) module, where
we move {{fineract-provider/src/integrationTest/}} to
{{fineract/integration-tests/src/test}}, and the Cargo stuff from
fineract-provider build - so that all ITs still work "as is now". That PR just
do JUST that, and nothing else :D BTw do you have anything in
https://github.com/apache/fineract/pull/1416 which this would require? Could we
"peel that" out from there into a separate new smaller PR, pre-req for this and
FINERACT-1190?
2. We create 1 PR more with a first IT using the Swagger client; the 1st would
be to move the {{testRetrieveAllClients()}} 1/2 of {{FineractClientTest}} after
merge of https://github.com/apache/fineract/pull/1428 into
{{fineract/integration-tests/}} - because we could now (hopefully) make it use
{{baseURL("https://localhost/fineract-provider/api/v1/";)}} instead of
{{baseURL("https://demo.fineract.dev/fineract-provider/api/v1/";)}}! I could
then 2nd try this for FINERACT-1218. Maybe we don't have to sink weeks into a
massive migration of all existing ITs.. that's huge work; it's perhaps OK to
have 2 different styles, old and new, even for a while?
[~aleks] if you would be interested in taking 1. (which you like would be more
"efficient" at than I could be, seeing how proficient you seem to be in all
matters re. Gradle...), then I'm quite motivated to have a go at 2. after (I
could probably even play with it in parallel already while you work on 1; if we
agree to push forward in that direction).
[~ptuomola] your valuable feedback and thoughts about this plan most welcome,
of course.
> Integration Tests using new Swagger Client API ("Fineract SDK")
> ---------------------------------------------------------------
>
> Key: FINERACT-1209
> URL: https://issues.apache.org/jira/browse/FINERACT-1209
> Project: Apache Fineract
> Issue Type: New Feature
> Reporter: Michael Vorburger
> Priority: Major
>
> Thanks to the progress in FINERACT-1189, I think we're closer than we have
> ever been to do something I have dreamt of :D for a long time... basically
> what we were discussing back in the comments of FINERACT-838, copy/paste:
> {quote}(...) include sample code in the repo building against the generated
> client libraries to test and illustrate their usage. (...) it's still not
> really "tested" at all, of course. We don't know if the generated code is a
> working client. (...) In an ideal world, we should have some sort of
> fineract-client-demo as a small separate project in the git root directory
> (of Apache Fineract core, not separately/outside!) which depends on
> fineract-client, and invokes at least some of the generated APIs. This IMHO
> should always be run, e.g. on Travis CI. We would of course need a "back-end
> server" - the easiest would probably be to run this against the local server
> we're anyway starting for integrationTest, in a separate new Gradle task with
> the appropriate dependencies?{quote}
> Thinking about this again with 2 months distance since writing above, what we
> probably REALLY should do, I don't know if instead of or in addition to a
> separate small new {{fineract-client-demo}}, is have (all?) of our ITs (in
> integrationTest) use the Swagger Client, instead of all those weird hand
> hard-coded *Utils and *Helper classes with RestAssured - that would be so
> much nicer!
> [~aleks] [~ChinmayKulkarni] [~ptuomola] [~manthan]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
