[ 
https://issues.apache.org/jira/browse/FINERACT-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216680#comment-17216680
 ] 

Aleksandar Vidakovic commented on FINERACT-1214:
------------------------------------------------

[~vorburger] I think you are right... if we would offer multiple JDK clients 
the question would also be where to stop... there are the ones out there who 
like OKHttp, others want HTTP Components etc. etc. Let's go with a reasonable 
choice (Retrofit, OKHttp, synchronous) and let's build 2 flavors (binary 
compatible JDK8 and JDK11) and publish those to Maven Central. I think that 
would make already 99% of the Fineract devs happy. Anyone interested in doing 
things more complex than that has probably enough knowledge to build their own 
client based on the Swagger file.

Offering an additional client in Typescript makes sense I think, because we 
would be immediate consumers with any Fineract web frontends... and anything 
else can be done fairly easily by anyone interested... in the end Fineract - as 
I understand - is not primarily a Ruby or Go or Python (insert your language 
here) shop. Unless there is significant interest in one of these languages 
there is probably no reason to offer (and maintain) them.

Like this we'll deliver 3 artifacts and we can keep a single code base of 
FineractClient.

(y)

> SDK Swagger Client Java API methods returning Rx Observable are not intuitive 
> for Java developers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-1214
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1214
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Michael Vorburger
>            Assignee: Aleksandar Vidakovic
>            Priority: Major
>             Fix For: 1.5.0
>
>
> I am, for the first time, attempting to fool around with our shiny new SDK 
> Client Java API, for FINERACT-1209.
> I've noticed that we have configured all the service methods to returned Rx 
> Observable. I'm aware of what that is, and perhaps I'm just too old and 
> grumpy, but I'm not sure I like that... and am concerned that average Joe 
> Java develpers using this SDK may get confused by it.
> Isn't the reality that in many many typical usages folks would just always do 
> {{.blockingSingle()}} anyway? And even if we went all-in reactive in our 
> SDK... A REST API call doesn't really return a _Stream_ - so the API as-is 
> doesn't seem natural, to me.
> Should we go mad and build and publish SEVERAL Fineract SDK Swagger Client 
> Java API libraries? io.reactivex for anyone smoking that, good ol' plain 
> simple non-reactive, modern Java 11, older Java 6, 7 AND 8 (Android?)... the 
> more the merrier?!
> [~aleks] [~ChinmayKulkarni] [~ptuomola] [~manthan]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to