[
https://issues.apache.org/jira/browse/FINERACT-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217112#comment-17217112
]
Michael Vorburger commented on FINERACT-1213:
---------------------------------------------
So it's interesting, the generated code for some API operations has a single
Request object, and for others the long list of parameters. It would IMHO be
nice and more consistent if we could make it have a Request for anything that
has more than a single (or 2, or 3?) parameters. I suspect this depends on some
Swagger annotation in those declarative Swagger classes we have everywhere? Or
do we need to actually change the *Resource classes themselves for this? Beware
- the REST API itself has to remain backwards compatible, of course. BTW:
FINERACT-1217 may be related to fixing this as well, but could be a fair (lot)
amount of work (I'm not sure); maybe just manually fixing up a few annotations
is easier to fix this in the short term; depends on "bad" the problem is;
haven't looked in detail).
> SDK Swagger Client Java API methods have (too) many parameters
> --------------------------------------------------------------
>
> Key: FINERACT-1213
> URL: https://issues.apache.org/jira/browse/FINERACT-1213
> Project: Apache Fineract
> Issue Type: Bug
> Components: SDK
> Reporter: Michael Vorburger
> Priority: Major
>
> I am, for the first time, attempting to fool around with our shiny new SDK
> Client Java API, for FINERACT-1209.
> It seems that at least some of its methods have many many parameters, e.g.
> {{org.apache.fineract.client.services.ClientApi.retrieveAll20(String, Long,
> String, String, String, String, String, String, Integer, Integer, String,
> String, Boolean)}}, and I was wondering if perhaps we could make it generate
> a Builder pattern for the Request instead?
> [~aleks] [~ChinmayKulkarni] [~ptuomola] [~manthan]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
