[
https://issues.apache.org/jira/browse/FINERACT-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218024#comment-17218024
]
Michael Vorburger commented on FINERACT-1233:
---------------------------------------------
Maybe it would be possible to define an Interceptor on Retrofit (or OkHttp)
which simply always add the dateFormat (fixed, hard-coded) and locale (from a
FineractClient Builder parameter), so it doesn't have to keep being repeated.
> Client Java SDK operations with LocalDate (and other date types) in Request
> shouldn't also require a dateFormat and locale in the request
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FINERACT-1233
> URL: https://issues.apache.org/jira/browse/FINERACT-1233
> Project: Apache Fineract
> Issue Type: Improvement
> Components: SDK
> Reporter: Michael Vorburger
> Assignee: Michael Vorburger
> Priority: Major
>
> Requests such as {{POST /offices}} have e.g. an {{openingDate}} which is of
> Java type {{LocalDate}}.
> Due to
> https://demo.fineract.dev/fineract-provider/api-docs/apiLive.htm#dates_and_numbers,
> a user of the Java Client has to also specify a dateFormat("yyyy-mm-dd") AND
> a locale("en_US"). From a Java API point of view, this doesn't really make
> much sense. (Because if it's a strong type, the implementation should
> serialize it however it sees fit; asking the user to specify the Date Format,
> but have the implementation provide the Serialization, mixes up layers of
> responsibility.)
> I'm not sure how to best address this. For the short term, I'll at least
> introduce a DATE_FORMAT = "yyyy-mm-dd" constant in {{FineractClient}} which
> can be used.
> PS: Date types are not consistent in the client, see FINERACT-1232.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
