[
https://issues.apache.org/jira/browse/FINERACT-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227864#comment-17227864
]
Aleksandar Vidakovic commented on FINERACT-1245:
------------------------------------------------
[~vorburger] The problem here is the generated code in fineract-client... and
we made the decision that we won't add any custom templates for the code
generator. As far as I see that would be the only way to get rid of that (I
think) one issue in the generated client code that fails on "-Werror". Well,
the other option we have is to fix that with a PR on OpenAPI directly.
But that's why the same code passes in fineract-client and fails in
integration-tests.
> Error Prone Bug Pattern JavaTimeDefaultTimeZone should be Error not just
> Warning
> --------------------------------------------------------------------------------
>
> Key: FINERACT-1245
> URL: https://issues.apache.org/jira/browse/FINERACT-1245
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Minor
> Fix For: 1.5.0
>
>
> This should be configured to be an Error, not just a Warning, and the
> occurrence fixed:
> {noformat}> Task :fineract-client:compileTestJava
>
> /home/vorburger/dev/Mifos/fineract/fineract-client/src/test/java/org/apache/fineract/integrationtests/newstyle/OfficeTest.java:40:
> warning: [JavaTimeDefaultTimeZone] LocalDate.now() is not allowed because it
> silently uses the system default time-zone. You must pass an explicit
> time-zone (e.g., ZoneId.of("America/Los_Angeles")) to this method.
>
>
> .openingDate(LocalDate.now()).dateFormat(dateFormat()).locale("en_US"))).getOfficeId()).isGreaterThan(0);
>
> ^
>
> (see https://errorprone.info/bugpattern/JavaTimeDefaultTimeZone)
>
> Did you mean
> '.openingDate(LocalDate.now(ZoneId.systemDefault())).dateFormat(dateFormat()).locale("en_US"))).getOfficeId()).isGreaterThan(0);'?
>
>
> 1 warning{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
