[
https://issues.apache.org/jira/browse/FINERACT-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234666#comment-17234666
]
Avik Ganguly commented on FINERACT-1203:
----------------------------------------
[~vorburger] [~aleks]
{quote}not sure what you mean, if I do ./gradlew war at the root of the latest
develop branch of the project, then I do get a
fineract-provider/build/libs/fineract-provider.war. Are you perhaps by mistake
just looking in build/libs instead of fineract-provider/build/libs? That
changed, not because of FINERACT-1203 but as part of FINERACT-1171. Will you
raise a PR to update the README to clarify this?
{quote}
Yes, I had checked both the build folders. Will update the documentation.
Seems some inconsistency with gradle. "./gradlew war" from both root of develop
branch and from inside fineract-provider was consistently skipping the final
task of war (noticeable with info/debug log level) and not producing the WAR
file. Deleting the gradle wrapper
(.gradle/wrapper/dists/gradle-6.7-bin/efvqh8uyq79v2n7rcncuhu9sv) and
reinstalling it helped resolve the issue.
{quote}Did you actually read the discussion in this issue?!
{quote}
Earlier I didn't :D. Navigated here from Git Blame of bootWar task since I
assumed documentation isn't updated and bootWar has replaced War.
> Make WAR non-executable to avoid confusion (because it's broken anyway)
> -----------------------------------------------------------------------
>
> Key: FINERACT-1203
> URL: https://issues.apache.org/jira/browse/FINERACT-1203
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Minor
> Fix For: 1.5.0
>
> Attachments: image-2020-11-18-14-08-00-290.png, war.log
>
>
> I've noticed that the WAR we build is not a traditional Tomcat only WAR, but
> a Spring Boot Executable WAR - but a broken one! :( Whereas our Executable
> JAR works of course, our WAR with {{java -jar
> fineract-provider/build/libs/fineract-provider.war}} fails to start, see
> attached {{war.log}}.
> [~ptuomola] and [~aleks] perhaps this is something one of you would like to
> look into?
> If you can fix this, then it poses the question why we would build and
> document and distribute and support two different artifacts. My vote, if this
> can be fixed, could be to unify on only having a (both "traditional AND
> Executable") WAR and no JAR. Unless there are reasons why that may be stupid,
> and both are useful, even if the problem above was fixed. Thoughts?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
