[ 
https://issues.apache.org/jira/browse/FINERACT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300879#comment-17300879
 ] 

Michael Vorburger commented on FINERACT-1306:
---------------------------------------------

[~ptuomola] comment on 
[https://github.com/apache/fineract/pull/1620#issuecomment-793353315] made me 
have a closer 2nd look at this one again today.

I could now reproduce what you are reporting here re. GET 
[https://localhost:8443/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false&parameterType=true&tenantIdentifier=default]
 :

On the current develop branch, with 
[3cc65f78278542da9af289d6e5a1e84e79192ef9|https://github.com/rrpawar96/fineract/commit/3cc65f78278542da9af289d6e5a1e84e79192ef9]
 for FINERACT-1173 that indeed returns, as reported above:
{code:json}
{
  "developerMessage": "The requested resource is not available.",
  "httpStatusCode": "404",
  "defaultUserMessage": "The requested resource is not available.",
  "userMessageGlobalisationCode": "error.msg.resource.not.found",
  "errors": [
    {
      "developerMessage": "Reporting meta-data entry not found.",
      "defaultUserMessage": "Reporting meta-data entry not found.",
      "userMessageGlobalisationCode": "error.msg.report.name.not.found",
      "parameterName": "id",
      "value": null,
      "args": [
        {
          "value": "Report Name: reportCategoryList"
        }
      ]
    }
  ]
}{code}
But before that change, yes you are right it used to return:
{code:json}
[
  {
    "report_id": 20,
    "report_name": "Funds Disbursed Between Dates Summary",
    "report_type": "Table",
    "report_subtype": null,
    "report_category": "Fund",
    "parameter_id": 76,
    "report_parameter_name": null,
    "parameter_name": "startDateSelect"
  },
  {
    "report_id": 20,
    "report_name": "Funds Disbursed Between Dates Summary",
    "report_type": "Table",
    "report_subtype": null,
    "report_category": "Fund",
    "parameter_id": 77,
    "report_parameter_name": null,
    "parameter_name": "endDateSelect"
  },
  {
    "report_id": 20,
    "report_name": "Funds Disbursed Between Dates Summary",
    "report_type": "Table",
    "report_subtype": null,
    "report_category": "Fund",
    "parameter_id": 78,
    "report_parameter_name": null,
    "parameter_name": "currencyIdSelectAll"
  }, ...{code}

And Rahul's 
https://github.com/rrpawar96/fineract/commit/3cc65f78278542da9af289d6e5a1e84e79192ef9
 seems to fixes this problem (I've not debugged why). But the SQL version 
number in that is wrong, we can't merged that as 
V155_1__add_stretchy_reports.sql.

So I'm OK to accept that fix. But we need a cleaner PR than Francis' 
https://github.com/apache/fineract/pull/1620 with the 10 commits - and should 
have a non-regression test for this, as in my (failed) first attempt to 
reproduce it.

I'll make a clean new PR! I'll keep "attribution" with your commits so that you 
are recognized for your work here, but I'll clean it all up.

> Reporting meta-data entry not found - All reports modules
> ---------------------------------------------------------
>
>                 Key: FINERACT-1306
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1306
>             Project: Apache Fineract
>          Issue Type: Bug
>          Components: Reports
>    Affects Versions: 1.5.0
>            Reporter: Francis Guchie
>            Assignee: Michael Vorburger
>            Priority: Major
>             Fix For: 1.5.0
>
>         Attachments: image-2021-01-27-09-41-45-780.png
>
>
> [https://ipaddress/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false&parameterType=true|https://diprom.biz/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false&parameterType=true]
> One gets the response payload below 
> {
>  "developerMessage": "The requested resource is not available.",
>  "httpStatusCode": "404",
>  "defaultUserMessage": "The requested resource is not available.",
>  "userMessageGlobalisationCode": "error.msg.resource.not.found",
>  "errors": [
>  {
>  "developerMessage": "Reporting meta-data entry not found.",
>  "defaultUserMessage": "Reporting meta-data entry not found.",
>  "userMessageGlobalisationCode": "error.msg.report.name.not.found",
>  "parameterName": "id",
>  "value": null,
>  "args": [
> { "value": "Report Name: reportCategoryList" }
> ]
>  }
>  ]
>  }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to