[ 
https://issues.apache.org/jira/browse/FINERACT-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Danish Jamal updated FINERACT-1387:
-----------------------------------
    Description: 
One of the missing field is  "depositType" and "subStatus" in generated 
"GetClientsSavingsAccounts" class(their are multiple fields missing in status 
model also).
 This model is used for the endpoint "clients/\{clientId}/accounts". Take a 
look at below json response which contains the actual response from the API.

 
{code:java}
// clients/{clientId}/accounts
{
  "groupLoanIndividualMonitoringAccounts": [],
  "savingsAccounts": [
    {
      "id": 3,
      "accountNo": "000000003",
      "externalId": "537",
      "productId": 1,
      "productName": "Passbook Savings",
      "shortProductName": "PBSV",
      "status": {
        "id": 100,
        "code": "savingsAccountStatusType.submitted.and.pending.approval",
        "value": "Submitted and pending approval",
        "submittedAndPendingApproval": true,
        "approved": false,
        "rejected": false,
        "withdrawnByApplicant": false,
        "active": false,
        "closed": false,
        "prematureClosed": false,
        "transferInProgress": false,
        "transferOnHold": false,
        "matured": false
      },
      "currency": {
        "code": "USD",
        "name": "US Dollar",
        "decimalPlaces": 2,
        "inMultiplesOf": 0,
        "displaySymbol": "$",
        "nameCode": "currency.USD",
        "displayLabel": "US Dollar ($)"
      },
      "accountType": {
        "id": 1,
        "code": "accountType.individual",
        "value": "Individual"
      },
      "timeline": {
        "submittedOnDate": [
          2020,
          8,
          18
        ],
        "submittedByUsername": "mifos",
        "submittedByFirstname": "App",
        "submittedByLastname": "Administrator"
      },
      "subStatus": {
        "id": 0,
        "code": "SavingsAccountSubStatusEnum.none",
        "value": "None",
        "none": true,
        "inactive": false,
        "dormant": false,
        "escheat": false,
        "block": false,
        "blockCredit": false,
        "blockDebit": false
      },
      "depositType": {
        "id": 100,
        "code": "depositAccountType.savingsDeposit",
        "value": "Savings"
      }
    },
    {
      "id": 1,
      "accountNo": "000000001",
      "productId": 1,
      "productName": "Passbook Savings",
      "shortProductName": "PBSV",
      "status": {
        "id": 300,
        "code": "savingsAccountStatusType.active",
        "value": "Active",
        "submittedAndPendingApproval": false,
        "approved": false,
        "rejected": false,
        "withdrawnByApplicant": false,
        "active": true,
        "closed": false,
        "prematureClosed": false,
        "transferInProgress": false,
        "transferOnHold": false,
        "matured": false
      },
      "currency": {
        "code": "USD",
        "name": "US Dollar",
        "decimalPlaces": 2,
        "inMultiplesOf": 0,
        "displaySymbol": "$",
        "nameCode": "currency.USD",
        "displayLabel": "US Dollar ($)"
      },
      "accountType": {
        "id": 1,
        "code": "accountType.individual",
        "value": "Individual"
      },
      "timeline": {
        "submittedOnDate": [
          2021,
          8,
          9
        ],
        "submittedByUsername": "mifos",
        "submittedByFirstname": "App",
        "submittedByLastname": "Administrator",
        "approvedOnDate": [
          2021,
          8,
          11
        ],
        "approvedByUsername": "mifos",
        "approvedByFirstname": "App",
        "approvedByLastname": "Administrator",
        "activatedOnDate": [
          2021,
          8,
          12
        ]
      },
      "subStatus": {
        "id": 0,
        "code": "SavingsAccountSubStatusEnum.none",
        "value": "None",
        "none": true,
        "inactive": false,
        "dormant": false,
        "escheat": false,
        "block": false,
        "blockCredit": false,
        "blockDebit": false
      },
      "lastActiveTransactionDate": [
        2021,
        8,
        12
      ],
      "depositType": {
        "id": 100,
        "code": "depositAccountType.savingsDeposit",
        "value": "Savings"
      }
    },
    {
      "id": 2,
      "accountNo": "000000002",
      "productId": 1,
      "productName": "Passbook Savings",
      "shortProductName": "PBSV",
      "status": {
        "id": 300,
        "code": "savingsAccountStatusType.active",
        "value": "Active",
        "submittedAndPendingApproval": false,
        "approved": false,
        "rejected": false,
        "withdrawnByApplicant": false,
        "active": true,
        "closed": false,
        "prematureClosed": false,
        "transferInProgress": false,
        "transferOnHold": false,
        "matured": false
      },
      "currency": {
        "code": "USD",
        "name": "US Dollar",
        "decimalPlaces": 2,
        "inMultiplesOf": 0,
        "displaySymbol": "$",
        "nameCode": "currency.USD",
        "displayLabel": "US Dollar ($)"
      },
      "accountBalance": 2423.000000,
      "accountType": {
        "id": 1,
        "code": "accountType.individual",
        "value": "Individual"
      },
      "timeline": {
        "submittedOnDate": [
          2021,
          3,
          20
        ],
        "submittedByUsername": "mifos",
        "submittedByFirstname": "App",
        "submittedByLastname": "Administrator",
        "approvedOnDate": [
          2021,
          8,
          11
        ],
        "approvedByUsername": "mifos",
        "approvedByFirstname": "App",
        "approvedByLastname": "Administrator",
        "activatedOnDate": [
          2021,
          8,
          12
        ]
      },
      "subStatus": {
        "id": 0,
        "code": "SavingsAccountSubStatusEnum.none",
        "value": "None",
        "none": true,
        "inactive": false,
        "dormant": false,
        "escheat": false,
        "block": false,
        "blockCredit": false,
        "blockDebit": false
      },
      "lastActiveTransactionDate": [
        2021,
        8,
        18
      ],
      "depositType": {
        "id": 100,
        "code": "depositAccountType.savingsDeposit",
        "value": "Savings"
      }
    }
  ],
  "guarantorAccounts": []
}
{code}

  was:
Field "depositType" and "subStatus" missing in generated 
"GetClientsSavingsAccounts" class.
This model is used for the endpoint "clients/\{clientId}/accounts". Take a look 
at below json response which contains the actual response from the API.

 
{code:java}
// clients/{clientId}/accounts
{
  "groupLoanIndividualMonitoringAccounts": [],
  "savingsAccounts": [
    {
      "id": 3,
      "accountNo": "000000003",
      "externalId": "537",
      "productId": 1,
      "productName": "Passbook Savings",
      "shortProductName": "PBSV",
      "status": {
        "id": 100,
        "code": "savingsAccountStatusType.submitted.and.pending.approval",
        "value": "Submitted and pending approval",
        "submittedAndPendingApproval": true,
        "approved": false,
        "rejected": false,
        "withdrawnByApplicant": false,
        "active": false,
        "closed": false,
        "prematureClosed": false,
        "transferInProgress": false,
        "transferOnHold": false,
        "matured": false
      },
      "currency": {
        "code": "USD",
        "name": "US Dollar",
        "decimalPlaces": 2,
        "inMultiplesOf": 0,
        "displaySymbol": "$",
        "nameCode": "currency.USD",
        "displayLabel": "US Dollar ($)"
      },
      "accountType": {
        "id": 1,
        "code": "accountType.individual",
        "value": "Individual"
      },
      "timeline": {
        "submittedOnDate": [
          2020,
          8,
          18
        ],
        "submittedByUsername": "mifos",
        "submittedByFirstname": "App",
        "submittedByLastname": "Administrator"
      },
      "subStatus": {
        "id": 0,
        "code": "SavingsAccountSubStatusEnum.none",
        "value": "None",
        "none": true,
        "inactive": false,
        "dormant": false,
        "escheat": false,
        "block": false,
        "blockCredit": false,
        "blockDebit": false
      },
      "depositType": {
        "id": 100,
        "code": "depositAccountType.savingsDeposit",
        "value": "Savings"
      }
    },
    {
      "id": 1,
      "accountNo": "000000001",
      "productId": 1,
      "productName": "Passbook Savings",
      "shortProductName": "PBSV",
      "status": {
        "id": 300,
        "code": "savingsAccountStatusType.active",
        "value": "Active",
        "submittedAndPendingApproval": false,
        "approved": false,
        "rejected": false,
        "withdrawnByApplicant": false,
        "active": true,
        "closed": false,
        "prematureClosed": false,
        "transferInProgress": false,
        "transferOnHold": false,
        "matured": false
      },
      "currency": {
        "code": "USD",
        "name": "US Dollar",
        "decimalPlaces": 2,
        "inMultiplesOf": 0,
        "displaySymbol": "$",
        "nameCode": "currency.USD",
        "displayLabel": "US Dollar ($)"
      },
      "accountType": {
        "id": 1,
        "code": "accountType.individual",
        "value": "Individual"
      },
      "timeline": {
        "submittedOnDate": [
          2021,
          8,
          9
        ],
        "submittedByUsername": "mifos",
        "submittedByFirstname": "App",
        "submittedByLastname": "Administrator",
        "approvedOnDate": [
          2021,
          8,
          11
        ],
        "approvedByUsername": "mifos",
        "approvedByFirstname": "App",
        "approvedByLastname": "Administrator",
        "activatedOnDate": [
          2021,
          8,
          12
        ]
      },
      "subStatus": {
        "id": 0,
        "code": "SavingsAccountSubStatusEnum.none",
        "value": "None",
        "none": true,
        "inactive": false,
        "dormant": false,
        "escheat": false,
        "block": false,
        "blockCredit": false,
        "blockDebit": false
      },
      "lastActiveTransactionDate": [
        2021,
        8,
        12
      ],
      "depositType": {
        "id": 100,
        "code": "depositAccountType.savingsDeposit",
        "value": "Savings"
      }
    },
    {
      "id": 2,
      "accountNo": "000000002",
      "productId": 1,
      "productName": "Passbook Savings",
      "shortProductName": "PBSV",
      "status": {
        "id": 300,
        "code": "savingsAccountStatusType.active",
        "value": "Active",
        "submittedAndPendingApproval": false,
        "approved": false,
        "rejected": false,
        "withdrawnByApplicant": false,
        "active": true,
        "closed": false,
        "prematureClosed": false,
        "transferInProgress": false,
        "transferOnHold": false,
        "matured": false
      },
      "currency": {
        "code": "USD",
        "name": "US Dollar",
        "decimalPlaces": 2,
        "inMultiplesOf": 0,
        "displaySymbol": "$",
        "nameCode": "currency.USD",
        "displayLabel": "US Dollar ($)"
      },
      "accountBalance": 2423.000000,
      "accountType": {
        "id": 1,
        "code": "accountType.individual",
        "value": "Individual"
      },
      "timeline": {
        "submittedOnDate": [
          2021,
          3,
          20
        ],
        "submittedByUsername": "mifos",
        "submittedByFirstname": "App",
        "submittedByLastname": "Administrator",
        "approvedOnDate": [
          2021,
          8,
          11
        ],
        "approvedByUsername": "mifos",
        "approvedByFirstname": "App",
        "approvedByLastname": "Administrator",
        "activatedOnDate": [
          2021,
          8,
          12
        ]
      },
      "subStatus": {
        "id": 0,
        "code": "SavingsAccountSubStatusEnum.none",
        "value": "None",
        "none": true,
        "inactive": false,
        "dormant": false,
        "escheat": false,
        "block": false,
        "blockCredit": false,
        "blockDebit": false
      },
      "lastActiveTransactionDate": [
        2021,
        8,
        18
      ],
      "depositType": {
        "id": 100,
        "code": "depositAccountType.savingsDeposit",
        "value": "Savings"
      }
    }
  ],
  "guarantorAccounts": []
}
{code}


> multiple field missing in savings account model ("GetClientsSavingsAccounts") 
> while fetching clients acccounts 
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-1387
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1387
>             Project: Apache Fineract
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Danish Jamal
>            Assignee: Danish Jamal
>            Priority: Major
>              Labels: fineract-client-sdk, gsoc2021, swagger
>             Fix For: 1.5.0
>
>
> One of the missing field is  "depositType" and "subStatus" in generated 
> "GetClientsSavingsAccounts" class(their are multiple fields missing in status 
> model also).
>  This model is used for the endpoint "clients/\{clientId}/accounts". Take a 
> look at below json response which contains the actual response from the API.
>  
> {code:java}
> // clients/{clientId}/accounts
> {
>   "groupLoanIndividualMonitoringAccounts": [],
>   "savingsAccounts": [
>     {
>       "id": 3,
>       "accountNo": "000000003",
>       "externalId": "537",
>       "productId": 1,
>       "productName": "Passbook Savings",
>       "shortProductName": "PBSV",
>       "status": {
>         "id": 100,
>         "code": "savingsAccountStatusType.submitted.and.pending.approval",
>         "value": "Submitted and pending approval",
>         "submittedAndPendingApproval": true,
>         "approved": false,
>         "rejected": false,
>         "withdrawnByApplicant": false,
>         "active": false,
>         "closed": false,
>         "prematureClosed": false,
>         "transferInProgress": false,
>         "transferOnHold": false,
>         "matured": false
>       },
>       "currency": {
>         "code": "USD",
>         "name": "US Dollar",
>         "decimalPlaces": 2,
>         "inMultiplesOf": 0,
>         "displaySymbol": "$",
>         "nameCode": "currency.USD",
>         "displayLabel": "US Dollar ($)"
>       },
>       "accountType": {
>         "id": 1,
>         "code": "accountType.individual",
>         "value": "Individual"
>       },
>       "timeline": {
>         "submittedOnDate": [
>           2020,
>           8,
>           18
>         ],
>         "submittedByUsername": "mifos",
>         "submittedByFirstname": "App",
>         "submittedByLastname": "Administrator"
>       },
>       "subStatus": {
>         "id": 0,
>         "code": "SavingsAccountSubStatusEnum.none",
>         "value": "None",
>         "none": true,
>         "inactive": false,
>         "dormant": false,
>         "escheat": false,
>         "block": false,
>         "blockCredit": false,
>         "blockDebit": false
>       },
>       "depositType": {
>         "id": 100,
>         "code": "depositAccountType.savingsDeposit",
>         "value": "Savings"
>       }
>     },
>     {
>       "id": 1,
>       "accountNo": "000000001",
>       "productId": 1,
>       "productName": "Passbook Savings",
>       "shortProductName": "PBSV",
>       "status": {
>         "id": 300,
>         "code": "savingsAccountStatusType.active",
>         "value": "Active",
>         "submittedAndPendingApproval": false,
>         "approved": false,
>         "rejected": false,
>         "withdrawnByApplicant": false,
>         "active": true,
>         "closed": false,
>         "prematureClosed": false,
>         "transferInProgress": false,
>         "transferOnHold": false,
>         "matured": false
>       },
>       "currency": {
>         "code": "USD",
>         "name": "US Dollar",
>         "decimalPlaces": 2,
>         "inMultiplesOf": 0,
>         "displaySymbol": "$",
>         "nameCode": "currency.USD",
>         "displayLabel": "US Dollar ($)"
>       },
>       "accountType": {
>         "id": 1,
>         "code": "accountType.individual",
>         "value": "Individual"
>       },
>       "timeline": {
>         "submittedOnDate": [
>           2021,
>           8,
>           9
>         ],
>         "submittedByUsername": "mifos",
>         "submittedByFirstname": "App",
>         "submittedByLastname": "Administrator",
>         "approvedOnDate": [
>           2021,
>           8,
>           11
>         ],
>         "approvedByUsername": "mifos",
>         "approvedByFirstname": "App",
>         "approvedByLastname": "Administrator",
>         "activatedOnDate": [
>           2021,
>           8,
>           12
>         ]
>       },
>       "subStatus": {
>         "id": 0,
>         "code": "SavingsAccountSubStatusEnum.none",
>         "value": "None",
>         "none": true,
>         "inactive": false,
>         "dormant": false,
>         "escheat": false,
>         "block": false,
>         "blockCredit": false,
>         "blockDebit": false
>       },
>       "lastActiveTransactionDate": [
>         2021,
>         8,
>         12
>       ],
>       "depositType": {
>         "id": 100,
>         "code": "depositAccountType.savingsDeposit",
>         "value": "Savings"
>       }
>     },
>     {
>       "id": 2,
>       "accountNo": "000000002",
>       "productId": 1,
>       "productName": "Passbook Savings",
>       "shortProductName": "PBSV",
>       "status": {
>         "id": 300,
>         "code": "savingsAccountStatusType.active",
>         "value": "Active",
>         "submittedAndPendingApproval": false,
>         "approved": false,
>         "rejected": false,
>         "withdrawnByApplicant": false,
>         "active": true,
>         "closed": false,
>         "prematureClosed": false,
>         "transferInProgress": false,
>         "transferOnHold": false,
>         "matured": false
>       },
>       "currency": {
>         "code": "USD",
>         "name": "US Dollar",
>         "decimalPlaces": 2,
>         "inMultiplesOf": 0,
>         "displaySymbol": "$",
>         "nameCode": "currency.USD",
>         "displayLabel": "US Dollar ($)"
>       },
>       "accountBalance": 2423.000000,
>       "accountType": {
>         "id": 1,
>         "code": "accountType.individual",
>         "value": "Individual"
>       },
>       "timeline": {
>         "submittedOnDate": [
>           2021,
>           3,
>           20
>         ],
>         "submittedByUsername": "mifos",
>         "submittedByFirstname": "App",
>         "submittedByLastname": "Administrator",
>         "approvedOnDate": [
>           2021,
>           8,
>           11
>         ],
>         "approvedByUsername": "mifos",
>         "approvedByFirstname": "App",
>         "approvedByLastname": "Administrator",
>         "activatedOnDate": [
>           2021,
>           8,
>           12
>         ]
>       },
>       "subStatus": {
>         "id": 0,
>         "code": "SavingsAccountSubStatusEnum.none",
>         "value": "None",
>         "none": true,
>         "inactive": false,
>         "dormant": false,
>         "escheat": false,
>         "block": false,
>         "blockCredit": false,
>         "blockDebit": false
>       },
>       "lastActiveTransactionDate": [
>         2021,
>         8,
>         18
>       ],
>       "depositType": {
>         "id": 100,
>         "code": "depositAccountType.savingsDeposit",
>         "value": "Savings"
>       }
>     }
>   ],
>   "guarantorAccounts": []
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to