[ https://issues.apache.org/jira/browse/FINERACT-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470653#comment-17470653 ]
Michael Vorburger commented on FINERACT-1480: --------------------------------------------- [~ptuomola] I've glanced briefly over your [https://github.com/apache/fineract/pull/2021/files] and gathered (without looking at the details) that this was some sort of "container specific" problem. As such, do you think we could / should have "test coverage" for that? Would this be easy to add to, and do you think be the right place for, adding a curl .../fineract.yaml to [https://github.com/apache/fineract/blob/develop/.github/workflows/build-docker.yml?] (BTW upon looking at that, it occured to me that what we're doing there should perhaps go into some sort of test-container.sh kind of script, at the root of the repo? Then it would be easy to launch locally as well; the GitHub Action could just call that.) > Swagger UI is broken (because fineract.yaml moved?) > --------------------------------------------------- > > Key: FINERACT-1480 > URL: https://issues.apache.org/jira/browse/FINERACT-1480 > Project: Apache Fineract > Issue Type: Bug > Affects Versions: 1.6.0 > Reporter: Michael Vorburger > Assignee: Petri Tuomola > Priority: Blocker > Fix For: 1.6.0 > > > While testing https://github.com/vorburger/www.fineract.dev/issues/11 and > following the first links mentioned on https://www.fineract.dev, namely > https://demo.fineract.dev/fineract-provider/swagger-ui/index.html (as well as > https://demo.fineract.dev/fineract-provider/swagger-ui/fineract.yaml) I have > noticed that the Swagger YAML and thus UI has recently been broken. > It's curious that the > https://github.com/apache/fineract/blob/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/SwaggeruiTest.java > did not catch this regression. It would be nice if this were addressed as > part of fixing this. Would it perhaps suffice to add a {{GET > /fineract-provider/swagger-ui/fineract.yaml}} (in addition to {{index.html}}) > to that test? Or is it a (Docker) Container Image specific regression? > [~ptuomola] or [~aleks] or maybe [~Manthan] perhaps digging into and finding > a solution for this interests you, or you want to point anyone at this issue. > (I won't be working on this, I'm just filing issues for what I find in the > Fineract.dev logs.) -- This message was sent by Atlassian Jira (v8.20.1#820001)