[
https://issues.apache.org/jira/browse/FINERACT-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470657#comment-17470657
]
Petri Tuomola commented on FINERACT-1480:
-----------------------------------------
Hi [~vorburger] - in this case I needed to make the same change 4 times: once
for WAR, another one for bootRun, another one for bootJar and finally one for
Docker. Out of these, the only one that is tested by our integration tests is
the WAR file.
I think this may be a bit of an outlier, as normally you could just make one
change that would update all the 4 distribution modes - but in this case I
could not think of any way of doing so. However, this is definitely not the
only case where we've ended up with different functionality / issues between
JAR vs Docker vs...
Given this, I think we should have a bit of a think re what are the "officially
supported" distribution artefacts and then ensure we have full testing coverage
for them. Rather than developing 4 different sets of integration tests covering
these 4 different distribution modes, perhaps we could drop the support for
some of these - and then run the full set of integration tests against the
remaining ones...
> Swagger UI is broken
> --------------------
>
> Key: FINERACT-1480
> URL: https://issues.apache.org/jira/browse/FINERACT-1480
> Project: Apache Fineract
> Issue Type: Bug
> Affects Versions: 1.6.0
> Reporter: Michael Vorburger
> Assignee: Petri Tuomola
> Priority: Blocker
> Fix For: 1.6.0
>
>
> While testing https://github.com/vorburger/www.fineract.dev/issues/11 and
> following the first links mentioned on https://www.fineract.dev, namely
> https://demo.fineract.dev/fineract-provider/swagger-ui/index.html (as well as
> https://demo.fineract.dev/fineract-provider/swagger-ui/fineract.yaml) I have
> noticed that the Swagger YAML and thus UI has recently been broken.
> It's curious that the
> https://github.com/apache/fineract/blob/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/SwaggeruiTest.java
> did not catch this regression. It would be nice if this were addressed as
> part of fixing this. Would it perhaps suffice to add a {{GET
> /fineract-provider/swagger-ui/fineract.yaml}} (in addition to {{index.html}})
> to that test? Or is it a (Docker) Container Image specific regression?
> [~ptuomola] or [~aleks] or maybe [~Manthan] perhaps digging into and finding
> a solution for this interests you, or you want to point anyone at this issue.
> (I won't be working on this, I'm just filing issues for what I find in the
> Fineract.dev logs.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
