[
https://issues.apache.org/jira/browse/FINERACT-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501739#comment-17501739
]
Michael Vorburger commented on FINERACT-1513:
---------------------------------------------
[http://blog2.vorburger.ch/2020/05/fineractdev-cicd-from-github-to-google.html]
is what I was looking for, from 2 years ago.
But I just realized something: So the way it used to work is that I set up
Docker Hub to pull the code from Git, and built it (on Docker Hub). I was able
to do with some clicking around after logging in to Docker Hub - but I was
using my personal Docker Hub login.
I'm not sure sharing THAT (vorburger's docker.com login) on a GitHub secret is
the best way to do this. I guess ideally we should create another Docker ID,
something like a fineract-bot(@apache.org), or something like that. Let's "do
this right" ... see INFRA-22954.
PS: While working on this, it occured to me that for
[https://www.fineract.dev|https://www.fineract.dev/] we actually already have a
container registry with an image from the latest develop branch (except it's
broken right now, see FINERACT-1519 =>
[https://github.com/vorburger/www.fineract.dev/issues/15,] but I'm hoping to
fix that). Do you guys prefer having Docker Hub, or would there be interest in
exposing that? (Only? Also? Separate develop & release?)
> Add Docker Hub credentials to Github Secrets
> --------------------------------------------
>
> Key: FINERACT-1513
> URL: https://issues.apache.org/jira/browse/FINERACT-1513
> Project: Apache Fineract
> Issue Type: Task
> Reporter: Aleksandar Vidakovic
> Assignee: Michael Vorburger
> Priority: Trivial
> Fix For: 1.7.0
>
>
> Make Docker Hub credentials available in Github Secrets in repo
> "apache/fineract" and expose them as variables:
> * DOCKER_HUB_USERNAME
> * DOCKER_HUB_PASSWORD
> Goal is to be able to login with a Github Action and push the stable Docker
> Images.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
