Adam Saghy created FINERACT-2233:
------------------------------------

             Summary: Rework journal entry handling logic in Loan module
                 Key: FINERACT-2233
                 URL: https://issues.apache.org/jira/browse/FINERACT-2233
             Project: Apache Fineract
          Issue Type: Improvement
            Reporter: Adam Saghy


In Fineract we have a "hard to maintain" solution for journal entry creation.

It relies on 2 steps:
 * Collecting existing loan transaction ids and collecting existing reversed 
loan transaction ids

 * At the end of the process (at least it should have been the last step, but 
it is not… 😞 ) we call

 ** 
org.apache.fineract.accounting.journalentry.service.JournalEntryWritePlatformServiceJpaRepositoryImpl#createJournalEntriesForLoan

This logic tries to calculate and create the journal entries for all relevant 
transactions.

However this logic is flaky and hard to maintain, easy to break:

https://issues.apache.org/jira/browse/FINERACT-2225 

We should rework this logic to do the following:
 * If we create a new loan transaction, lets create immediately the journal 
entries as well

 * We can choose from 2 options:

 ** Explicitly call journal entry creation service

 ** Write an internal listener which catches all the new loan transactions and 
create the journal entries



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to