[
https://issues.apache.org/jira/browse/FINERACT-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Saghy closed FINERACT-1264.
--------------------------------
Resolution: Invalid
> Email Campaigns with Pentaho Reporting Attachments are broken
> -------------------------------------------------------------
>
> Key: FINERACT-1264
> URL: https://issues.apache.org/jira/browse/FINERACT-1264
> Project: Apache Fineract
> Issue Type: Bug
> Components: Reports
> Reporter: Michael Vorburger
> Priority: Critical
> Labels: email
>
> While working on FINERACT-1173, I've noticed that
> {{org.apache.fineract.infrastructure.campaigns.email.service.EmailCampaignWritePlatformCommandHandlerImpl.generateAttachments(EmailCampaign,
> ScheduledEmailAttachmentFileFormat, Map<String, String>, String,
> StringBuilder)}} use of
> {{org.apache.fineract.infrastructure.dataqueries.service.ReadReportingService.generatePentahoReportAsOutputStream(String,
> String, Map<String, String>, Locale, AppUser, StringBuilder)}} calls code
> that is completely commented out.
> This was, apparently, broken during the migration from Mifos to Fineract,
> because of the Pentaho removal.
> Fixing that will take a little bit of refactoring. I'd like to do that only
> after having completed FINERACT-1173 (and FINERACT-1177) and having the 2nd
> version of [https://github.com/vorburger/fineract-pentaho]. Once that is
> done, we can pick this up.
> We'll need to change {{ReportingProcessService}} to not be tied to
> {{javax.ws.rs.core.Response}}, as Aleks has done in
> [https://github.com/apache/fineract/pull/1416], so that will be part of the
> answer to fix this. (Although I would suggest that instead of instead of an
> {{OutputStream}} in the Reporting Plugin API we use a
> {{com.google.common.io.ByteSource}}, which can be easily adapted to the
> {{org.springframework.core.io.InputStreamSource}} that
> {{org.springframework.mail.javamail.MimeMessageHelper.addAttachment()}} digs;
> but that's a detail.)
> [~aleks] and [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
