[
https://issues.apache.org/jira/browse/FINERACT-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048836#comment-18048836
]
Yvana Kengne commented on FINERACT-2410:
----------------------------------------
Hello Adam, thanks for your reply. I was working on a different issue,
FINERACT_2422, and my build was successful, but when I submitted my review
i received a mail from my github telling me that 99% of the check had
failed but can be merged .
Does this mean my work is wrong or something?
I am confused right now
please Help me understand
thanks yvana
> Rework ProgressiveEMICalculator to work only with DTOs
> ------------------------------------------------------
>
> Key: FINERACT-2410
> URL: https://issues.apache.org/jira/browse/FINERACT-2410
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Adam Saghy
> Assignee: Ahmed Adel
> Priority: Major
> Fix For: 1.15.0
>
>
> EmiCalculator should only accept pure DTOs (no JPA entities, not even part of
> jpa entities like “Embeddable classes”), which only contains the required
> data. The argument DTOs should also not contain any entities, embeddable
> classes, etc.
> Example:
> * {{LoanScheduleModelRepaymentPeriod}} is a DTO, but it contains entity:
> {{LoanInterestRecalcualtionAdditionalDetails}}
> * {{LoanRepaymentScheduleInstallment}} is a JPA entity, should not be
> accepted as argument.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
