[ 
https://issues.apache.org/jira/browse/FINERACT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18052193#comment-18052193
 ] 

Adam Monsen commented on FINERACT-2423:
---------------------------------------

Great work team!

develop at {{ea1609120f}} has the patch, all the usual linting/build/tests 
passed, and the new [Verify Liquibase Backward Compatibility 
test|https://github.com/apache/fineract/blob/ea1609120f79dedb75d90f44afc328ee6cff6a97/.github/workflows/verify-liquibase-backward-compatibility.yml]
 passed on the PR branch.

I tried one more manual acceptance test: I [built a release binary 
tarball|https://fineract.apache.org/docs/current/#_step_6_create_distribution] 
fromĀ {{ea1609120f}} and [ran 
it|https://fineract.apache.org/docs/current/#_run_from_binary]. The server log 
did NOT have the original liquibase warning/error. Yay! See 
[^server-log-after-fix.txt]

> liquibase warning for space in migration 0072 filename
> ------------------------------------------------------
>
>                 Key: FINERACT-2423
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2423
>             Project: Apache Fineract
>          Issue Type: Task
>          Components: Database
>            Reporter: Adam Monsen
>            Assignee: Monica
>            Priority: Trivial
>         Attachments: liquibase-error-full-stacktrace.txt, 
> server-log-after-fix.txt
>
>
> Seen in logs while running Fineract:
> {code:none}
> 2025-12-19 09:53:32.278 - WARN 192547  [      no-tenant] --- [           
> main] liquibase.resource                       : Error handling URI syntax 
> for file inside jar. Defaulting to previous behavior.
> java.net.URISyntaxException: Illegal character in path at index 47: 
> //db/changelog/tenant/parts/0072_add_result_and status_to_command_source.xml
>       at java.base/java.net.URI$Parser.fail(URI.java:2995)
>       at java.base/java.net.URI$Parser.checkChars(URI.java:3166)
>       at java.base/java.net.URI$Parser.parseHierarchical(URI.java:3248)
>       at java.base/java.net.URI$Parser.parse(URI.java:3207)
>       at java.base/java.net.URI.<init>(URI.java:645)
>       at 
> liquibase.resource.AbstractResource.handlePathForJarfile(AbstractResource.java:45)
>       at liquibase.resource.AbstractResource.<init>(AbstractResource.java:30)
> ...
> {code}
> I found this while [testing the 1.14.0 release 
> candidate|https://fineract.apache.org/docs/current/#_run_from_binary]. I 
> think it is trivial, but annoying.
> I'll take a look. Should be simple/safe enough to fix in changelog-tenant.xml.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to