[
https://issues.apache.org/jira/browse/FINERACT-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18053684#comment-18053684
]
Adam Monsen commented on FINERACT-2158:
---------------------------------------
The in-progress PR uses a good solution.
Tangent/idealism: In general I'd rather see more build/test/check
independence/portability to [avoid vendor lock-in (vendor in this case is
GitHub)|https://ploum.net/2026-01-05-unteaching_github.html]. Doesn't really
apply in this case (since this is specific to GitHub PRs), but there are better
examples in {{~/.github/workflows}} of GitHub Actions that could be moved into
scripts that would work locally/anywhere (e.g. with Docker) and simplified to
just run those scripts.
> ensure every PR on GitHub references a Fineract JIRA ticket
> -----------------------------------------------------------
>
> Key: FINERACT-2158
> URL: https://issues.apache.org/jira/browse/FINERACT-2158
> Project: Apache Fineract
> Issue Type: Task
> Components: Build
> Reporter: Adam Monsen
> Priority: Minor
>
> Every PR (pull request) at [https://github.com/apache/fineract/pulls] must be
> linked to JIRA issue, hence, must start with {{FINERACT-N: }} where {{N}} is
> an existing Fineract Jira ticket number.
> This ticket proposes to automatically verify these requirements are met.
> At the least, dynamically/automatically confirm the title of the PR starts
> with {{FINERACT-N: }}. Implement with a bot/service provided by [Apache
> Infrastructure|https://infra.apache.org/], GitHub Actions, or similar.
> Additionally, consider verifying the ticket actually exists in Jira, but only
> if this is helpful, necessary, and expedient. For example:
> {code:bash}
> ISSUE_ID=2158
> HTTP_CODE=$(curl -I -s -o /dev/null --write-out "%{http_code}"
> https://issues.apache.org/jira/browse/FINERACT-$ISSUE_ID)
> [[ $HTTP_CODE -eq 200 ]]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
