[ https://issues.apache.org/jira/browse/FINERACT-2453 ]
Edward Kang deleted comment on FINERACT-2453:
---------------------------------------
was (Author: JIRAUSER312056):
Ahh, I see now what you mean. After investigating, I understand now that most
of the transaction types that also don't affect loan schedules are already
filtered out in the SQL and LoanTransactionService. Like you said, there is no
reason to reprocess those.
However, I traced the transaction list back through the services and
repository, and noticed that we allow ACCRUAL_ACTIVITY. I see this is
definitely intentional since it is used to trigger loan and charge processing
in reprocessProgressiveLoanTransactions() before any other transactions are
processed. However, it seems that ACCRUAL_ACTIVITY will still reach the
log.warn(), since it doesn't have an explicit handler or log.debug() in
processLatestTransaction, and is not gated against before processing each
transaction. This is the one transaction type out of the many that I believe
still result in a log.warn() being triggered.
I will do some testing locally to determine if this is truly an issue, and
report back.
> Improve logging of transaction processor to account for remaining transaction
> types
> -----------------------------------------------------------------------------------
>
> Key: FINERACT-2453
> URL: https://issues.apache.org/jira/browse/FINERACT-2453
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Edward Kang
> Assignee: Edward Kang
> Priority: Minor
>
> This works on the TODO item listed in processLatestTransaction() in the
> AdvancedPaymentScheduleTransactionProcessor. "TODO: Cover rest of the
> transaction types."
> Existing code creates a log.warn() for many acceptable transaction types,
> which is undesirable.
> The plan is:
> * Remove the log.warn() for transaction types that don't impact the loan
> scheduling process.
> * Group the remaining 19 transaction types based on their function and
> log.debug() their functionality and why they are excluded from being handled.
> * Only use log.warn() when the transaction type is INVALID.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
