[ 
https://issues.apache.org/jira/browse/FINERACT-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18055950#comment-18055950
 ] 

AMAN MITTAL edited comment on FINERACT-2462 at 2/2/26 3:39 PM:
---------------------------------------------------------------

[~meonkeys] Usually its one commit per PR, but there are exceptions were 
multiple People are working on same pr take example of some of the merged pr 
below

[https://github.com/apache/fineract/pull/5358/commits]
[https://github.com/apache/fineract/pull/5350/commits]

another example (open)

[https://github.com/apache/fineract/pull/5401/commits]

So technically, it becomes {*}per PR, per person commit{*}. :)

 


was (Author: JIRAUSER310703):
[~meonkeys] Usually its one commit per PR, but there are exceptions were 
multiple People are working on same pr take example of some of the merged pr 
below

[https://github.com/apache/fineract/pull/5358/commits]
[https://github.com/apache/fineract/pull/5350/commits]

https://github.com/apache/fineract/pull/5401/commits

So technically, it becomes {*}per PR, per person commit{*}. :)

 

> Add a github action which checks if PR follows one person per commit 
> guidelines
> -------------------------------------------------------------------------------
>
>                 Key: FINERACT-2462
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2462
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: AMAN MITTAL
>            Priority: Minor
>              Labels: beginner-friendly
>
> According to contributing guidelines, FINERACT follows one person per commit, 
> so i think we can add a github action that automatically informs the PR that 
> it has multiple commits per user



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to