airajena commented on PR #8: URL: https://github.com/apache/fineract-chat-archive/pull/8#issuecomment-3863575628
> I rewrote the commit log messages, excluding the string `FINERACT-2171: ` from each. It just takes up space. I'll add it to the commit log message when I merge to main (and I'm going to do a traditional merge, not squash -- I like preserving these incremental commits for posterity). > > I have force-pushed your branch, so you'll have to fetch and do a hard reset on your end. Sorry for not warning you first -- I don't plan on doing this often. > > If you'd like to add any text to the commit log messages, go right ahead. Thanks @meonkeys — I’m committed to maintaining this after MVP and I’ll keep improving it as we go. I synced to your force-push and will sign all new commits going forward. Addressing your comments: - Removed `final` from SlackApiClient and MarkdownRenderer. - Simplified daily Markdown output to `time - user - message`, with the time linked to the permalink. - README now explains how `SLACK_TOKEN` is created (Slack app → bot → scopes → install → `xoxb-` token). - Removed `chat:write` from required scopes to keep least-privilege; if Slack returns `missing_scope`, we’ll add the scope it reports and re-install. Re: Slack SDK vs custom HttpClient — I kept it minimal to reduce dependencies. I’m happy to switch to the official Slack Java client if you prefer. Re: commonmark — I kept rendering simple for MVP, but I can adopt commonmark-java if you’d like. Thanks again for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
