[ 
https://issues.apache.org/jira/browse/FINERACT-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057976#comment-18057976
 ] 

Adam Monsen edited comment on FINERACT-2478 at 2/11/26 8:08 PM:
----------------------------------------------------------------

LGTM. Merged! I made a few other changes too. Please review the latest commits. 
Summary:
 # reformatted timestamps and threads (See attached archive.webp screenshot)
 # improved instructions in readme
 # upgraded to latest gradle
 # use/expect Java 25 LTS

Will you start the github pages work?


was (Author: meonkeys):
LGTM. Merged! I made a few other changes too. Please review the latest commits. 
Summary:
 # reformatted timestamps and threads (See attached archive.webp screenshot)
 # improved instructions in readme
 # upgraded to latest gradle
 # use/expect Java 25 LTS

Will you figure out what we need to do to make it served via github pages?

> make Slack messages discoverable by search engines (v2)
> -------------------------------------------------------
>
>                 Key: FINERACT-2478
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2478
>             Project: Apache Fineract
>          Issue Type: Improvement
>    Affects Versions: 1.14.0
>            Reporter: Adam Monsen
>            Assignee: Adam Monsen
>            Priority: Minor
>         Attachments: archive.webp
>
>
> [~airajena] here's the continuation of FINERACT-2171. Feel free to break this 
> into multiple tickets (I couldn't figure out how to create an epic).
> [The archiver|https://github.com/apache/fineract-chat-archive] is working. 
> Great job! I set up a [repo to store output 
> data|https://github.com/mifos/chat-archive]. That repo has the github action 
> and proper config to archive #fineract in the Mifos Slack workspace. Many 
> things are working: Idempotency, permalinks, Slack API calls, index 
> generation. There are a couple bugs, please see below.
> ▶️ I think the next thing is to serve the archive via GitHub Pages. Will you 
> start work on that?
> ✅ [We might want newlines between 
> messages|https://raw.githubusercontent.com/mifos/chat-archive/refs/heads/main/docs/daily/fineract/2026-02-09.md].
>  Agreed?
> ✅ Looks like [Slack link 
> formatting|https://docs.slack.dev/messaging/formatting-message-text/#linking-urls]
>  is a bit different than Markdown, so we'll need to do some reformatting 
> (unless we can get messages in a different format from the API). See 
> [2026-02-06.md|https://github.com/mifos/chat-archive/blob/main/docs/daily/fineract/2026-02-06.md?plain=1#L8]
>  for an example:
> {code:none}
> <https://lists.apache.org/thread/b2jwr5ql47bt1t600js7t237rkc1q6w2|this is a 
> very recently added requirement>
> {code}
> instead of
> {code:none}
> [this is a very recently added 
> requirement](https://lists.apache.org/thread/b2jwr5ql47bt1t600js7t237rkc1q6w2)
> {code}
> ✅ Will you please review [my update archive 
> workflow|https://github.com/mifos/chat-archive/blob/main/.github/workflows/update-archive.yml]?
>  LMK if you have any suggestions (feel free to start a PR against that repo).
> ✅ Changing {{fetch.lookback.days}} from {{1}} to {{2}} (in 
> config/archive.properties) seems to have no effect (or I did something 
> wrong). When I changed it from {{2}} to {{3}} and re-ran, then it got the 
> last 3 days except yesterday. So there might be some 
> indexing/off-by-one/date-handling bug. Note this is now configured with a 
> {{LOOKBACK_DAYS}} env var. *UPDATE: Never mind, this is working as intended.* 
> I was expecting a Markdown file for every day, but some days have no 
> activity, so no Markdown file is created for those days.
> ✅ Ah, here's a bug: I changed lookback days to {{1}} and it [deleted two days 
> from the 
> index|https://github.com/mifos/chat-archive/commit/e6df3bb1e0608781f487936ccd59ea9319241767].
>  {*}UPDATE{*}: I think we fixed this in [PR 
> #1|https://github.com/mifos/chat-archive/pull/1].
> ✅ We should sort links in {{docs/daily/CHANNEL/index.md}} if we aren't 
> already (we might be).
> ▶️ You've been using AI... should we add an {{AGENTS.md}} file?
> ✅ I suppose we should convert :wave: to 👋, and so on. Thoughts?
> ▶️ Once we're using GitHub Pages, don't apply Markdown formatting directly in 
> Java code (e.g. bolding usernames). Use CSS classes and a stylesheet.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to