[
https://issues.apache.org/jira/browse/FINERACT-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Victor Romero updated FINERACT-2515:
------------------------------------
Description:
Fix PortfolioAccountType in order to use enum values
[https://github.com/apache/fineract/blob/develop/fineract-core/src/main/java/org/apache/fineract/portfolio/account/PortfolioAccountType.java]
Fix these lines of code (also make sure to remove the TODO)
// TODO: bad practice and unnecessary code! why not just use the enum values
themselves!?!
public boolean isSavingsAccount()
{ return this.equals(SAVINGS); }
// TODO: bad practice and unnecessary code! why not just use the enum
values themselves!?!
public boolean isLoanAccount()
{ return this.equals(LOAN); }
was:
Fix PortfolioAccountType in order to use enum values
[https://github.com/apache/fineract/blob/develop/fineract-core/src/main/java/org/apache/fineract/portfolio/account/PortfolioAccountType.java]
Fix these lines of code
// TODO: bad practice and unnecessary code! why not just use the enum values
themselves!?!
public boolean isSavingsAccount() {
return this.equals(SAVINGS);
}
// TODO: bad practice and unnecessary code! why not just use the enum
values themselves!?!
public boolean isLoanAccount() {
return this.equals(LOAN);
}
> Fix PortfolioAccountType in order to use enum values
> ----------------------------------------------------
>
> Key: FINERACT-2515
> URL: https://issues.apache.org/jira/browse/FINERACT-2515
> Project: Apache Fineract
> Issue Type: Task
> Reporter: Victor Romero
> Priority: Trivial
>
> Fix PortfolioAccountType in order to use enum values
>
> [https://github.com/apache/fineract/blob/develop/fineract-core/src/main/java/org/apache/fineract/portfolio/account/PortfolioAccountType.java]
>
> Fix these lines of code (also make sure to remove the TODO)
>
> // TODO: bad practice and unnecessary code! why not just use the enum values
> themselves!?!
> public boolean isSavingsAccount()
> { return this.equals(SAVINGS); }
> // TODO: bad practice and unnecessary code! why not just use the enum
> values themselves!?!
> public boolean isLoanAccount()
> { return this.equals(LOAN); }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
