[
https://issues.apache.org/jira/browse/FINERACT-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062264#comment-18062264
]
Adam Monsen edited comment on FINERACT-2503 at 3/2/26 9:21 PM:
---------------------------------------------------------------
Your changes in CONTRIBUTING.md look good.
It looks like you have created two identical PRs from two different branches in
your fork. Both have commit ace4a3560c9810533990a9e2c67d3d1c86df4827, then one
identical change only differing by timestamp. Each PR must only contain
discrete changes.
You're changing the generated file index.html with no explanation as to why.
You've added commented-out code in 859bce08a46886593e7e6476f5430c768cf8efdc /
98d4d4fc1cb9ea46bbcfa6914cc6f95577ae5b68 – please don't do that.
Please also go through all my PR review comments one by one and respond/resolve
them directly (as appropriate) so I don't have to chase each one down. If
you've already responded, just link to your own response, don't copy-paste.
I'm concerned at the frequent use of the !important CSS label.
[https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/important]
says this is bad practice.
This is going to need a lot of work, and I'm still not sure how to review the
CSS changes besides looking at screenshots. I wish we had a CSS validator to
use before and after. Are you doing any CSS validation / static checking?
You might consider starting over and doing smaller, carefully explained changes
to the CSS code. I can't follow what's changing, currently. Maybe someone else
would be better at reviewing it, I don't know. Maybe try to recruit more help
in chat or on the dev mailing list, or if you happen to know an expert at CSS.
What the heck is all this CSS, anyway? Do we actually have/need animation logic
in there? What is this "Cube Loader" stuff?
Can you reduce the number of colors? Go ahead and redefine our palette if it
helps. We shouldn't have more than a few colors, and just a few overrides for
dark mode. Simplify, simplify, simplify.
Maybe abstraction would help. Have you considered an compiled/intermediate
language to simplify the static CSS markup? Maybe something like SASS or SCSS?
(sorry, I'm not really sure what's available / best).
was (Author: meonkeys):
Good news: Your changes in CONTRIBUTING.md look good.
Bad news:
It looks like you have created two identical PRs from two different branches in
your fork. Both have commit ace4a3560c9810533990a9e2c67d3d1c86df4827, then one
identical change only differing by timestamp. Each PR must only contain
discrete changes.
You're changing the generated file index.html with no explanation as to why.
You've added commented-out code in 859bce08a46886593e7e6476f5430c768cf8efdc /
98d4d4fc1cb9ea46bbcfa6914cc6f95577ae5b68 – please don't do that.
Please also go through all my PR review comments one by one and respond/resolve
them directly (as appropriate) so I don't have to chase each one down. If
you've already responded, just link to your own response, don't copy-paste.
I'm concerned at the frequent use of the !important CSS label.
[https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/important]
says this is bad practice.
This is going to need a lot of work, and I'm still not sure how to review the
CSS changes besides looking at screenshots. I wish we had a CSS validator to
use before and after. Are you doing any CSS validation / static checking?
You might consider starting over and doing smaller, carefully explained changes
to the CSS code. I can't follow what's changing, currently. Maybe someone else
would be better at reviewing it, I don't know. Maybe try to recruit more help
in chat or on the dev mailing list, or if you happen to know an expert at CSS.
What the heck is all this CSS, anyway? Do we actually have/need animation logic
in there? What is this "Cube Loader" stuff?
Can you reduce the number of colors? Go ahead and redefine our palette if it
helps. We shouldn't have more than a few colors, and just a few overrides for
dark mode. Simplify, simplify, simplify.
Maybe abstraction would help. Have you considered an compiled/intermediate
language to simplify the static CSS markup? Maybe something like SASS or SCSS?
(sorry, I'm not really sure what's available / best).
> [fineract-site] Fix WCAG 2.1 AA contrast violations and improve mobile
> responsiveness
> -------------------------------------------------------------------------------------
>
> Key: FINERACT-2503
> URL: https://issues.apache.org/jira/browse/FINERACT-2503
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Ali Mahmood
> Assignee: Adam Monsen
> Priority: Minor
> Labels: accessibility, fineract-site, wcag
> Attachments: AIM Score.png, fineract footer.png, fineract.png
>
>
> Here is the quick summary of what fixes I made regarding both WCAG Contrast
> and responsivness across all devices :
> *Responsiveness Fixes* :
> *Fixed the Sidebar:* I fixed the responsiveness of sidebar with following
> changes:
> 1. Added closing button
> 2. Fixed alignment of both logo and organization name
> 3. Added proper padding for all sidebar options
> *Cleaned Up the Header:* I centered the logo and moved the menu button to the
> left. I also removed the cluttered links from the top bar to make it look
> much cleaner on mobile.
> *Uniform Boxes & Spacing*: I made all the feature boxes the same size so they
> look balanced and reduced the extra "empty space" between sections to make
> the page scroll better.
> *Better Mobile View:* Fixed overlapping text and icons so the site works
> perfectly on small phone screens (like 375px).
> *Contrast Fixes :*
> *Switched to Light Theme Footer:* I moved the footer/reference section to a
> light theme with dark teal text. This fixed the remaining accessibility
> issues—we now have 0 contrast errors!
> *Switched to Light Theme Navbar :* I moved the navbar section to light theme
> so it contrasts perfectly with apache fineract's original theme and looks
> good.
> Improved AIM Score : Before contrast fixes ,AIM Score was *1.7*. Now the AIM
> score is *"9.8"*
> Related: FINERACT-2484
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
