[
https://issues.apache.org/jira/browse/FINERACT-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Kang updated FINERACT-2518:
----------------------------------
Description:
*Problem*
After investigating, it turns out PRs have been failing due to a mismatch
between the CI/CD date locality (Asia/Kolkata), which is the default tenant
timezone, and date locality used in SavingsAccountsExternalIdTests (UTC). At
certain times of the day, we get a date mismatch, which corresponds to the
errors we have been getting.
The time of the CI/CD commit failures was around 1-2pm US Central. Notably,
this is after 12am in Asia/Kolkata, resulting in a future date.
Failed CI/CD tests are similar between commits. We get failed data validation
due to: ...cannot.be.before.client.activation.date. We can also see that in
submitSavingsAccountApplication(), we use a date of 2026-03-03, but the
submittedOnDate we pass in is 02 March 2026. Below is a picture showing these
errors from github.
!Screenshot 2026-03-02 at 6.53.46 PM.png!
*Fix*
Proposition is to change the hardcoded UTC to getLocalDateOfTenant() which is
also hardcoded to Asia/Kolkata. This is also better than using system date,
which could depend on the location of the user if testing locally.
was:
*Problem*
After investigating, it turns out PRs have been failing due to a mismatch
between the CI/CD date locality (Asia/Kolkata), which is the default tenant
timezone, and date locality used in SavingsAccountsExternalIdTests (UTC). At
certain times of the day, we get a date mismatch, which corresponds to the
errors we have been getting.
The time of the CI/CD commit failures was around 1-2pm US Central. Notably,
this is after 12am in Asia/Kolkata, resulting in a future date.
Failed CI/CD tests are similar between commits. We get failed data validation
due to: ...cannot.be.before.client.activation.date. Below is a picture of the
errors we get from github.
!Screenshot 2026-03-02 at 6.53.46 PM.png!
*Fix*
Proposition is to change the hardcoded UTC to getLocalDateOfTenant() which is
also hardcoded to Asia/Kolkata. This is also better than using system date,
which could depend on the location of the user if testing locally.
> Fix to Savings account tests date timezone
> ------------------------------------------
>
> Key: FINERACT-2518
> URL: https://issues.apache.org/jira/browse/FINERACT-2518
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Edward Kang
> Assignee: Edward Kang
> Priority: Minor
> Attachments: Screenshot 2026-03-02 at 6.53.46 PM-1.png, Screenshot
> 2026-03-02 at 6.53.46 PM.png
>
>
> *Problem*
> After investigating, it turns out PRs have been failing due to a mismatch
> between the CI/CD date locality (Asia/Kolkata), which is the default tenant
> timezone, and date locality used in SavingsAccountsExternalIdTests (UTC). At
> certain times of the day, we get a date mismatch, which corresponds to the
> errors we have been getting.
> The time of the CI/CD commit failures was around 1-2pm US Central. Notably,
> this is after 12am in Asia/Kolkata, resulting in a future date.
> Failed CI/CD tests are similar between commits. We get failed data validation
> due to: ...cannot.be.before.client.activation.date. We can also see that in
> submitSavingsAccountApplication(), we use a date of 2026-03-03, but the
> submittedOnDate we pass in is 02 March 2026. Below is a picture showing these
> errors from github.
> !Screenshot 2026-03-02 at 6.53.46 PM.png!
> *Fix*
> Proposition is to change the hardcoded UTC to getLocalDateOfTenant() which is
> also hardcoded to Asia/Kolkata. This is also better than using system date,
> which could depend on the location of the user if testing locally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
