[ 
https://issues.apache.org/jira/browse/FINERACT-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062792#comment-18062792
 ] 

Adam Monsen commented on FINERACT-2503:
---------------------------------------

{quote}The site is static HTML with no build step{quote}

False. See merge commit c645df68a5d4267238024824db66cf0e72103e25

re: !important...

{quote}I reduced the count from 138 to 91 by using ID-level specificity 
wherever possible;
the remaining ones have no CSS-only alternative.{quote}

I don't understand or this just doesn't answer my question. Please explain.

{quote}If you're satisified by my approach{quote}

Go ahead and clean up your branches, per my other comments they are not 
reviewable as-is.
 

> [fineract-site] Fix WCAG 2.1 AA contrast violations and improve mobile 
> responsiveness
> -------------------------------------------------------------------------------------
>
>                 Key: FINERACT-2503
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2503
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Ali Mahmood
>            Assignee: Adam Monsen
>            Priority: Minor
>              Labels: accessibility, fineract-site, wcag
>         Attachments: AIM Score.png, fineract footer.png, fineract.png
>
>
> Here is the quick summary of what fixes I made regarding both WCAG Contrast 
> and responsivness across all devices : 
> *Responsiveness Fixes* :
> *Fixed the Sidebar:* I fixed the responsiveness of sidebar with following 
> changes:
> 1. Added closing button 
> 2. Fixed alignment of both logo and organization name 
> 3. Added proper padding for all sidebar options  
> *Cleaned Up the Header:* I centered the logo and moved the menu button to the 
> left. I also removed the cluttered links from the top bar to make it look 
> much cleaner on mobile.
> *Uniform Boxes & Spacing*: I made all the feature boxes the same size so they 
> look balanced and reduced the extra "empty space" between sections to make 
> the page scroll better.
> *Better Mobile View:* Fixed overlapping text and icons so the site works 
> perfectly on small phone screens (like 375px).
> *Contrast Fixes :*
> *Switched to Light Theme Footer:* I moved the footer/reference section to a 
> light theme with dark teal text. This fixed the remaining accessibility 
> issues—we now have 0 contrast errors!
> *Switched to Light Theme Navbar :* I moved the navbar section to light theme 
> so it contrasts perfectly with apache fineract's original theme and looks 
> good.
> Improved AIM Score : Before contrast fixes ,AIM Score was *1.7*. Now the AIM 
> score is *"9.8"*
> Related: FINERACT-2484



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to