nidhiii128 commented on PR #14: URL: https://github.com/apache/fineract-chat-archive/pull/14#issuecomment-4006361130
Hi @meonkeys, I have updated the PR with the following changes: Rebased on upstream/main: I've synchronized my branch with the latest project changes, including the new CONTRIBUTING.md which I have reviewed. Added Indexing Fix: I added a separate commit to fix IndexRenderer. It now uses a recursive scan (Files.walk) to discover the new nested directory structure, restoring the 'Years' and 'Months' links. Un-squashed Commits: As requested, I have not squashed my changes. I kept the original hierarchy implementation and the subsequent indexing fix as distinct commits to make the progression easier to review. Force-Push with Lease: Because the rebase changed the branch history, I performed a push --force-with-lease to update the PR. I used the "lease" flag to ensure no remote work was accidentally overwritten. Verification: Idempotency: I ran the updateChatArchive task multiple times locally; it correctly identifies no changes are needed once the files exist. Manual Check: Verified that the Channel, Year, and Month index pages all link correctly to the new YYYY/MM/DD/index.html structure. Assets: Confirmed that CSS and breadcrumbs work correctly at the new directory depth. If these changes meet your expectations and the logic is approved, I will proceed to fork mifos/chat-archive and submit the migration PR to move the historical .html files into the new YYYY/MM/DD/ directory structure. Please let me know if you need any further adjustments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
