Ambika-Sony commented on PR #5597: URL: https://github.com/apache/fineract/pull/5597#issuecomment-4043987432
Hi , thank you for the update! I am completely on board with splitting the work 50/50. I've seen your latest push, Edward—I will pull those changes into my local environment shortly to sync up. I'll continue working on my assigned modules today. Great to be working with you both on this! On Thu, 12 Mar, 2026, 8:04 am edk12564, ***@***.***> wrote: > *edk12564* left a comment (apache/fineract#5597) > <https://github.com/apache/fineract/pull/5597#issuecomment-4043487572> > > sure. you can split ;) > > I see now after some reading that we can just have 2 PRs since the tests > in our PR get run. Sorry about that. > > I made a lot of progress, and build was working locally. However, I am not > done yet. I am just pushing so @Ambika-Sony > <https://github.com/Ambika-Sony> can access these changes. Since they are > required to pass builds/tests. > > I also found some endpoints in FinancialActivityAccountsApiResource that > were named createGLAccount. However, it seems these endpoints actually map > a GLAccount to a FinancialActivityAccount, and creating a GL Account is > done in GLAccountResourceApi. I changed the operationId here to more > closely match it's actual function. > > Thank you for being patient with me! > > Also, before merging, we must also make sure the order with Self-Service > removal is correct. Currently I left self-service changes in. However, when > the full merge to delete goes through, i can refactor to remove those > changes. Just depends on which gets merged first. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/5597#issuecomment-4043487572>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BIN7S2GGRKMAB3DPNTFQBOD4QIO2XAVCNFSM6AAAAACWLGS4MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANBTGQ4DONJXGI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
