SamaSVM commented on PR #5578:
URL: https://github.com/apache/fineract/pull/5578#issuecomment-4046167174
@adamsaghy From the task I can see that **response.resourceId is always the
same as response.clientId**.
After analysis I found that in
DatatableWriteServiceImpl at line 1159 we set:
```
Long resourceId = appTableId;
if (datatableUtil.isMultirowDatatable(columnHeaders)) {
resourceId = sqlGenerator.fetchPK(keyHolder);
}
```
If we don't enter the if block (single-row datatable) then resourceId =
appTableId = clientId for CLIENT entity. As I understand this is the reason why
response.resourceId == response.clientId.
I think the problem is in publishHookEvent where resourceId was not promoted
to the root level and not cleared from response, unlike officeId.
So I decided to apply the same approach as for officeId — promote resourceId
to the root level and clear it in response.
Note: I am still learning this codebase so I might have got something wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
