Ambika-Sony opened a new pull request, #5614:
URL: https://github.com/apache/fineract/pull/5614

   This PR standardizes the operationId naming convention (methodName + 
entityName + ByClause) for the Savings and Infrastructure modules.
   
   As discussed with @edk12564 and approved by @adam-saghy, this work is part 
of a collaborative effort to resolve deduplication in the OpenAPI spec. I have 
synchronized the integration tests and merged shared test fixes from 
FINERACT-2501 to ensure the build remains green
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x ] Acknowledge that we will not review PRs that are not passing the 
build _("green")_ - it is your responsibility to get a proposed PR to pass the 
build, not primarily the project's maintainers.
   - [ x] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [xx ] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [ x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   
   Your assigned reviewer(s) will follow our [guidelines for code 
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to