vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2927275015
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/FixedDepositProductsApiResource.java:
##########
@@ -125,14 +130,11 @@ public class FixedDepositProductsApiResource {
Mandatory Fields for Cash based accounting (accountingRule = 2):
savingsReferenceAccountId, savingsControlAccountId, interestOnSavingsAccountId,
incomeFromFeeAccountId, transfersInSuspenseAccountId,
incomeFromPenaltyAccountId""")
@RequestBody(required = true, content = @Content(schema =
@Schema(implementation =
FixedDepositProductsApiResourceSwagger.PostFixedDepositProductsRequest.class)))
@ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
FixedDepositProductsApiResourceSwagger.PostFixedDepositProductsResponse.class)))
- public String create(@Parameter(hidden = true) final String
apiRequestBodyAsJson) {
-
- final CommandWrapper commandRequest = new
CommandWrapperBuilder().createFixedDepositProduct().withJson(apiRequestBodyAsJson)
- .build();
-
- final CommandProcessingResult result =
this.commandsSourceWritePlatformService.logCommandSource(commandRequest);
-
- return this.toApiJsonSerializer.serialize(result);
+ public FixedDepositProductCreateResponse create(@Parameter(hidden = true)
final FixedDepositProductCreateRequest request) {
Review Comment:
What's with this here? This apparently belongs to the "savings" domain...
why is this command processing refactoring still here? We said we would focus
on "interest rate"... so let's do that please. The PR is still VERY large...
let's migrate other domains in a separate PR please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
