meonkeys commented on code in PR #56:
URL: https://github.com/apache/fineract-site/pull/56#discussion_r2932738542
##########
README.md:
##########
@@ -56,6 +56,21 @@ docker run --rm -v "${PWD}:/src" -w /src/site-src
fineract-site build
docker run --rm -it -p 1313:1313 -v "${PWD}:/src" -w /src/site-src
fineract-site serve
```
+## Verifying ASF homepage footer checks locally
+
+Apache Whimsy validates that the public homepage includes specific ASF-required
+footer links and legal text. Before opening a PR, verify the footer locally.
+
+### Build and run checks
+```bash
+docker build -t fineract-site .
+docker run --rm -u "$(id -u):$(id -g)" -v "$PWD:/src" -w /src/site-src
fineract-site build
+docker run --rm -u "$(id -u):$(id -g)" -v "$PWD:/src" -w /src/site-src
fineract-site check
+
+Serve the site locally
+
+docker run --rm -it -u "$(id -u):$(id -g)" -v "$PWD:/src" -w /src/site-src -p
1313:1313 fineract-site serve
+
Review Comment:
hmm, it works, but now every time whimsy changes, we'll have to update
`scripts/whimsy-check.py`. Why not just run the actual whimsy site checker Ruby
script(s)? You can do all that within the Docker image/container without
changing our dev process. Once whimsy and its dependencies are installed, run
it in `run_checks()` in `scripts/site-tool.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
