mariiaKraievska commented on code in PR #5584:
URL: https://github.com/apache/fineract/pull/5584#discussion_r2939861616


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloanproduct/repository/WorkingCapitalLoanProductRepository.java:
##########
@@ -38,9 +38,11 @@ public interface WorkingCapitalLoanProductRepository
     boolean existsByShortName(String shortName);
 
     @Query("""
-            SELECT wclp FROM WorkingCapitalLoanProduct wclp
+            SELECT DISTINCT wclp FROM WorkingCapitalLoanProduct wclp

Review Comment:
   I added distinct here because we using  left join for 
paymentAllocationRules. With `SELECT DISTINCT wclp` we will get all 
paymentAllocationRules attached to that product, but the product itself will 
appear only once in the result.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to