[ 
https://issues.apache.org/jira/browse/FINERACT-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18066118#comment-18066118
 ] 

Vignesh commented on FINERACT-2520:
-----------------------------------

Hi [~adamsaghy] ,

I have updated the Pull Request (#5592) with the requested fixes.

Before the final force-push, I verified the build locally using: {{./gradlew 
spotbugsMain spotbugsTest checkstyleMain checkstyleTest}}

Specifically for my changes, I have:
 # Corrected the decimal precision using {{stripTrailingZeros()}} to ensure 
consistency across MySQL and PostgreSQL.

 # Integrated the disbursement charges into the 
{{ProgressiveLoanScheduleGenerator}} and updated the unit tests accordingly.

 # Ensured the commit is properly signed with the {{-s}} flag to satisfy the 
DCO requirement.

The GitHub Actions are currently running and I am monitoring them to ensure all 
checks turn green. Thank you for the guidance! 
!image-2026-03-16-20-46-26-665.png!

> Loan charges are missed at disbursement
> ---------------------------------------
>
>                 Key: FINERACT-2520
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2520
>             Project: Apache Fineract
>          Issue Type: Bug
>    Affects Versions: 1.14.0
>            Reporter: Adam Saghy
>            Assignee: Adam Saghy
>            Priority: Major
>              Labels: beginner, beginner-friendly
>         Attachments: image-2026-03-16-20-46-26-665.png
>
>
> You’ll need a loan charge, %Amount, due at specific date.
> You’ll either add the charge to the loan *product* or to the loan account 
> before approval/disbursement.
> Steps to reproduce:
>  # Create a loan with the above charge added.
>  # The loan must have *progressive* repayment schedule
>  # Disburse the loan
> Expected result:
>  * the loan has the charges calculated and added
> Actual result:
>  * loan misses the charges already added
> Note: it works correctly with cummulative loans.
>  
> *Acceptance criteria*
>  * Disbursement charges can be applied to progressive loans



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to