vidakovic commented on code in PR #5657:
URL: https://github.com/apache/fineract/pull/5657#discussion_r2971905290
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/ClientAddressWriteService.java:
##########
@@ -18,15 +18,17 @@
*/
package org.apache.fineract.portfolio.address.service;
-import org.apache.fineract.infrastructure.core.api.JsonCommand;
-import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
+import java.util.List;
+import org.apache.fineract.portfolio.address.data.ClientAddressCreateResponse;
+import org.apache.fineract.portfolio.address.data.ClientAddressUpdateResponse;
+import org.apache.fineract.portfolio.client.data.ClientAddressRequest;
import org.apache.fineract.portfolio.client.domain.Client;
-public interface AddressWritePlatformService {
+public interface ClientAddressWriteService {
- CommandProcessingResult addClientAddress(Long clientId, Long
addressTypeId, JsonCommand command);
+ ClientAddressCreateResponse createClientAddress(ClientAddressRequest
request);
Review Comment:
We are not running out of disk space... even if the request classes for 2
different commands have exactly the same attributes... put them in 2 different
classes... sometimes duplication is your friend... because next week someone
will have the idea of adding something to the create command... or update... or
both... and: the automatic handler selection won't work properly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
