San-43 opened a new pull request, #5689: URL: https://github.com/apache/fineract/pull/5689
## Description This PR fixes [FINERACT-1152](https://issues.apache.org/jira/browse/FINERACT-1152); loan reschedule validation and term-variation generation for EMI changes with `endDate` when other reschedule changes (for example `extraTerms`) are submitted together. Previously, EMI/end-date validation effectively depended on the current installment schedule, which could reject valid requests where the end date only exists in the projected post-reschedule schedule. ## Changes - Updates EMI/end-date validation to enforce: - both fields are required together - `emi` must be positive - `endDate` must not be before `rescheduleFromDate` - Builds projected installment due dates using pending reschedule variations, then creates EMI term variations using those projected dates up to `endDate` - Returns a validation error when `endDate` is before the next projected installment date - Adds/updates tests: - unit tests for validator behavior - integration test covering EMI + extra terms using projected future schedule - Updates Swagger request model with `endDate` and `emi` fields for create-reschedule request payload examples I would like to mention #5619 since it helped me to have a better overall view of the problem and the potential fix. Hope this goes well. Pls let me know if anything should be changed. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
