vidakovic commented on code in PR #5622: URL: https://github.com/apache/fineract/pull/5622#discussion_r3004535212
########## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/productmix/api/ProductMixApiResource.java: ########## @@ -34,18 +35,25 @@ import java.util.Collection; import java.util.HashSet; import java.util.Set; +import java.util.function.Supplier; import lombok.RequiredArgsConstructor; -import org.apache.fineract.commands.domain.CommandWrapper; -import org.apache.fineract.commands.service.CommandWrapperBuilder; -import org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformService; +import org.apache.fineract.command.core.CommandDispatcher; import org.apache.fineract.infrastructure.core.api.ApiRequestParameterHelper; -import org.apache.fineract.infrastructure.core.data.CommandProcessingResult; import org.apache.fineract.infrastructure.core.serialization.ApiRequestJsonSerializationSettings; Review Comment: This doesn't look right here... these belong to the legacy manual JSON parsing mechanics... that the stuff we want to get rid of: - `ApiRequestJsonSerializationSettings` - `DefaultToApiJsonSerializer` Also: no use of `PlatformSecurityContext`; we should define all authorization constraints in `SecurityConfig.java`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
